New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Optional pipeline_id #25338
Merged
+14
−18
Merged
Remove Optional pipeline_id #25338
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.
Loading status checks…
Remove Optional pipeline_id
- Loading branch information
commit 5c3bda025144118fc8dd67a3f975d8f91fd25e78
ProTip!
Use n and p to navigate between commits in a pull request.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Not sure if changing this unsafe block is even ok. Assumed that WorkerScriptLoadOrigin's
pipeline_idis never None because it is now changed to be a non-Optional and only created incomponents/script/dom/serviceworkerregistration.rsandcomponents/script/dom/worker.rsas a non-Optional (after changes)