Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSet more ANGLE shader translation properties for WebGL 2 #25344
Conversation
highfive
commented
Dec 19, 2019
|
Heads up! This PR modifies the following files:
|
highfive
commented
Dec 19, 2019
|
@bors-servo try=wpt |
webgl: Set more ANGLE shader translation properties for WebGL 2.
|
|
|
Some nits but mostly LGTM. |
|
|
The gl-get-frag-data-location.html is new because the test previously returned early when the compiling the program failed. Now that it doesn't, we hit different errors. The new GL error is almost certainly caused by disabling the compat mode, since it's using ALPHA. |
|
Oh good, compat mode again. |
|
@bors-servo r=asajeffrey |
|
|
|
|
|
@bors-servo retry |
|
|
jdm commentedDec 19, 2019
•
edited
Fixes #25034.