Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upimplement HTMLOutputElement.value #25412
Merged
Conversation
highfive
commented
Jan 1, 2020
|
Heads up! This PR modifies the following files:
|
|
I am certain this is passing more tests than I've already fixed metadata for. |
bors-servo
added a commit
that referenced
this pull request
Jan 1, 2020
Now passing output tests as well as anyone HTMLOutputElement now works. I believe layout as well as script is working for it, since it works by putting strings into a child Text node and lays itself out exactly like a span, not requiring any special case rendering like textareas or input elements. Remaining failures are one mutation test case that everyone else is also failing and probably represents a test/spec mismatch, and all the validation-related tests since we don't have any form-validation hooks. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #25002 (GitHub issue number if applicable) <!-- Either: --> - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
pshaughn
changed the title
|
|
|
@bors-servo try=wpt |
bors-servo
added a commit
that referenced
this pull request
Jan 1, 2020
implement HTMLOutputElement.value HTMLOutputElement now works. I believe layout as well as script is working for it, since it works by putting strings into a child Text node and lays itself out exactly like a span, not requiring any special case rendering like textareas or input elements. Remaining failures are one mutation test case that everyone else is also failing and probably represents a test/spec mismatch, and all the validation-related tests since we don't have any form-validation hooks. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #25002 (GitHub issue number if applicable) <!-- Either: --> - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
| @@ -2017,6 +2017,16 @@ impl Node { | |||
| parent.owner_doc().remove_script_and_layout_blocker(); | |||
| } | |||
|
|
|||
| // https://dom.spec.whatwg.org/multipage/#string-replace-all | |||
| pub fn string_replace_all(string: DOMString, parent: &Node) { | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
pshaughn
Jan 2, 2020
Author
Member
I went for consistency with replace_all:
servo/components/script/dom/node.rs
Lines 1973 to 1974 in 7281336
This comment has been minimized.
This comment has been minimized.
Manishearth
Jan 3, 2020
Member
Oh, wait, I thought it wasn't on Node, and then was suggesting that it should be. I didn't notice that it was :)
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 3, 2020
implement HTMLOutputElement.value HTMLOutputElement now works. I believe layout as well as script is working for it, since it works by putting strings into a child Text node and lays itself out exactly like a span, not requiring any special case rendering like textareas or input elements. Remaining failures are one mutation test case that everyone else is also failing and probably represents a test/spec mismatch, and all the validation-related tests since we don't have any form-validation hooks. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #25002 (GitHub issue number if applicable) <!-- Either: --> - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
Oh, this was just that Mac filter-intermittents python thing... |
bors-servo
added a commit
that referenced
this pull request
Jan 3, 2020
implement HTMLOutputElement.value HTMLOutputElement now works. I believe layout as well as script is working for it, since it works by putting strings into a child Text node and lays itself out exactly like a span, not requiring any special case rendering like textareas or input elements. Remaining failures are one mutation test case that everyone else is also failing and probably represents a test/spec mismatch, and all the validation-related tests since we don't have any form-validation hooks. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #25002 (GitHub issue number if applicable) <!-- Either: --> - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
No need to run a full try. We can retry the merge instead. |
bors-servo
added a commit
that referenced
this pull request
Jan 6, 2020
implement HTMLOutputElement.value HTMLOutputElement now works. I believe layout as well as script is working for it, since it works by putting strings into a child Text node and lays itself out exactly like a span, not requiring any special case rendering like textareas or input elements. Remaining failures are one mutation test case that everyone else is also failing and probably represents a test/spec mismatch, and all the validation-related tests since we don't have any form-validation hooks. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #25002 (GitHub issue number if applicable) <!-- Either: --> - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Jan 7, 2020
implement HTMLOutputElement.value HTMLOutputElement now works. I believe layout as well as script is working for it, since it works by putting strings into a child Text node and lays itself out exactly like a span, not requiring any special case rendering like textareas or input elements. Remaining failures are one mutation test case that everyone else is also failing and probably represents a test/spec mismatch, and all the validation-related tests since we don't have any form-validation hooks. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #25002 (GitHub issue number if applicable) <!-- Either: --> - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Jan 7, 2020
implement HTMLOutputElement.value HTMLOutputElement now works. I believe layout as well as script is working for it, since it works by putting strings into a child Text node and lays itself out exactly like a span, not requiring any special case rendering like textareas or input elements. Remaining failures are one mutation test case that everyone else is also failing and probably represents a test/spec mismatch, and all the validation-related tests since we don't have any form-validation hooks. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #25002 (GitHub issue number if applicable) <!-- Either: --> - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Jan 7, 2020
implement HTMLOutputElement.value HTMLOutputElement now works. I believe layout as well as script is working for it, since it works by putting strings into a child Text node and lays itself out exactly like a span, not requiring any special case rendering like textareas or input elements. Remaining failures are one mutation test case that everyone else is also failing and probably represents a test/spec mismatch, and all the validation-related tests since we don't have any form-validation hooks. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #25002 (GitHub issue number if applicable) <!-- Either: --> - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pshaughn commentedJan 1, 2020
HTMLOutputElement now works. I believe layout as well as script is working for it, since it works by putting strings into a child Text node and lays itself out exactly like a span, not requiring any special case rendering like textareas or input elements.
Remaining failures are one mutation test case that everyone else is also failing and probably represents a test/spec mismatch, and all the validation-related tests since we don't have any form-validation hooks.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors