Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd "active parser was aborted boolean" to Document #25414
Merged
+25
−21
Conversation
highfive
commented
Jan 1, 2020
|
Heads up! This PR modifies the following files:
|
highfive
commented
Jan 1, 2020
|
|
|
@bors-servo try=wpt |
bors-servo
added a commit
that referenced
this pull request
Jan 1, 2020
Attempt at #24458 [draft] Let's see how this does in tests. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
That's strange; the only unexpected tests are the blank reftest problem. I expected this change to pass at least one of the many currently-failing document.open/document.write tests. |
|
It appears that all the tests relevant to this are filtered as intermittent! |
pshaughn
changed the title
|
@bors-servo try=wpt |
bors-servo
added a commit
that referenced
this pull request
Jan 2, 2020
Add "active parser was aborted boolean" to Document Aborting the document now definitely prevents a subsequent document.open from working, per spec as seen in #24458. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [x] These changes fix #24458 and fix #21279 <!-- Either: --> - [X] There are tests for these changes (currently intermittent in #21279, this will make them deterministically pass) <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
What are the test files that should no longer be treated as intermittent after these changes? You can add |
I did, #21279 (It was just two subcases in one file) |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 3, 2020
Add "active parser was aborted boolean" to Document Aborting the document now definitely prevents a subsequent document.open from working, per spec as seen in #24458. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [x] These changes fix #24458 and fix #21279 <!-- Either: --> - [X] There are tests for these changes (currently intermittent in #21279, this will make them deterministically pass) <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Jan 3, 2020
Add "active parser was aborted boolean" to Document Aborting the document now definitely prevents a subsequent document.open from working, per spec as seen in #24458. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [x] These changes fix #24458 and fix #21279 <!-- Either: --> - [X] There are tests for these changes (currently intermittent in #21279, this will make them deterministically pass) <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pshaughn commentedJan 1, 2020
•
edited
Aborting the document now definitely prevents a subsequent document.open from working, per spec as seen in #24458.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors