Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for border-radius #25423

Merged
merged 3 commits into from Jan 6, 2020
Merged

Add support for border-radius #25423

merged 3 commits into from Jan 6, 2020

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Jan 3, 2020 •
edited

Fixes #25040
SimonSapin added 3 commits Jan 3, 2020
@SimonSapin
Apply border-radius when painting borders
962c85b
@SimonSapin
Refactor creation of `webrender_api::CommonItemProperties`
cbf467b
@SimonSapin
Clip background-color to border-radius
Loading status checks…
347d582
@SimonSapin SimonSapin added this to In progress in Layout 2020 via automation Jan 3, 2020
@highfive
Copy link

highfive commented Jan 3, 2020

Heads up! This PR modifies the following files:

  • @emilio: components/style/properties/longhands/border.mako.rs, components/style/properties/shorthands/border.mako.rs
@highfive
Copy link

highfive commented Jan 3, 2020

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@nox
Copy link
Member

nox commented Jan 6, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 6, 2020

📌 Commit 347d582 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Jan 6, 2020

⌛ Testing commit 347d582 with merge 2bad94b...
bors-servo added a commit that referenced this pull request Jan 6, 2020
@bors-servo
Auto merge of #25423 - servo:border-radius, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2bad94b 
Add support for border-radius

Fixes #25040
@bors-servo
Copy link
Contributor

bors-servo commented Jan 6, 2020

💔 Test failed - status-taskcluster
@SimonSapin
Copy link
Member Author

SimonSapin commented Jan 6, 2020

@bors-servo retry

  • #24726
  • A number of timeouts on Linux (in layout-2013 mode so likely unrelated):
  ▶ TIMEOUT [expected OK] /_webgl/conformance/state/gl-object-get-calls.html
  ▶ TIMEOUT [expected OK] /offscreen-canvas/the-offscreen-canvas/size.attributes.reflect.setidlzero.worker.html
  ▶ TIMEOUT [expected OK] /offscreen-canvas/fill-and-stroke-styles/2d.pattern.repeat.unrecognised.worker.html
  ▶ TIMEOUT [expected OK] /css/css-flexbox/getcomputedstyle/flexbox_computedstyle_align-content-space-around.html
  ▶ TIMEOUT [expected OK] /fetch/api/redirect/redirect-origin.any.worker.html
  ▶ TIMEOUT [expected OK] /_webgl/conformance/attribs/gl-vertex-attrib-zero-issues.html
  ▶ TIMEOUT [expected OK] /_webgl/conformance/canvas/buffer-offscreen-test.html
  ▶ TIMEOUT [expected OK] /referrer-policy/gen/top.http-rp/origin/a-tag/cross-http.no-redirect.http.html
  ▶ TIMEOUT [expected OK] /css/css-align/content-distribution/place-content-shorthand-005.html
  ▶ TIMEOUT [expected OK] /dom/events/Event-dispatch-order-at-target.html
  ▶ TIMEOUT [expected OK] /_mozilla/mozilla/webgl/history.html
  ▶ TIMEOUT [expected OK] /referrer-policy/gen/top.meta/unsafe-url/xhr/same-https.no-redirect.http.html
  ▶ TIMEOUT [expected OK] /referrer-policy/gen/top.meta/origin/xhr/same-https.no-redirect.http.html
@bors-servo
Copy link
Contributor

bors-servo commented Jan 6, 2020

⌛ Testing commit 347d582 with merge 0b54c81...
bors-servo added a commit that referenced this pull request Jan 6, 2020
@bors-servo
Auto merge of #25423 - servo:border-radius, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0b54c81 
Add support for border-radius

Fixes #25040
@bors-servo bors-servo mentioned this pull request Jan 6, 2020
Merged
7 of 7 tasks complete
@bors-servo
Copy link
Contributor

bors-servo commented Jan 6, 2020

☀️ Test successful - status-taskcluster
Approved by: nox
Pushing 0b54c81 to master...
@bors-servo bors-servo merged commit 347d582 into master Jan 6, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Layout 2020 automation moved this from In progress to Merged / resolved Jan 6, 2020
@bors-servo bors-servo deleted the border-radius branch Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
A-layout/2020
Projects
Layout 2020
  
Merged / resolved
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Border-radius in Layout 2020
4 participants
@SimonSapin @highfive @nox @bors-servo
You can’t perform that action at this time.