Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PutForwards to implemented attributes that lacked it #25450

Merged
merged 1 commit into from Jan 23, 2020
Merged

Add PutForwards to implemented attributes that lacked it #25450

merged 1 commit into from Jan 23, 2020
+23 −82

Conversation

@pshaughn
Copy link
Member

pshaughn commented Jan 7, 2020

Added PutForwards to three relLists and one style. The style already had a test; I added tests for relLists, including one relList that we have commented out right now.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes advance #9990 to be caught up with the attributes we have so far; many unimplemented attributes will need PutForwards when implemented.
  • There are tests for these changes OR
@highfive
Copy link

highfive commented Jan 7, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webidls/ElementCSSInlineStyle.webidl, components/script/dom/webidls/HTMLAnchorElement.webidl, components/script/dom/webidls/HTMLLinkElement.webidl, components/script/dom/webidls/HTMLAreaElement.webidl
  • @KiChjang: components/script/dom/webidls/ElementCSSInlineStyle.webidl, components/script/dom/webidls/HTMLAnchorElement.webidl, components/script/dom/webidls/HTMLLinkElement.webidl, components/script/dom/webidls/HTMLAreaElement.webidl
@servo-wpt-sync servo-wpt-sync mentioned this pull request Jan 7, 2020
Merged
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Jan 7, 2020

Opened new PR for upstreamable changes.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#21062.
@Manishearth
Copy link
Member

Manishearth commented Jan 7, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 7, 2020

📌 Commit 3b0907c has been approved by Manishearth
@highfive highfive assigned Manishearth and unassigned paulrouget Jan 7, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Jan 7, 2020

⌛ Testing commit 3b0907c with merge 371674f...
bors-servo added a commit that referenced this pull request Jan 7, 2020
@bors-servo
Auto merge of #25450 - pshaughn:putforwards, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
371674f 
Add PutForwards to implemented attributes that lacked it

Added PutForwards to three relLists and one style. The style already had a test; I added tests for relLists, including one relList that we have commented out right now.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes advance #9990 to be caught up with the attributes we have so far; many unimplemented attributes will need PutForwards when implemented.

<!-- Either: -->
- [X] There are tests for these changes OR

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 7, 2020

💔 Test failed - status-taskcluster
@Manishearth
Copy link
Member

Manishearth commented Jan 7, 2020 

  ▶ Unexpected subtest result in /html/dom/idlharness.https.html?include=HTML.*:
  └ PASS [expected FAIL] HTMLLinkElement interface: attribute relList
  ▶ Unexpected subtest result in /html/dom/idlharness.https.html?include=HTML.*:
  └ PASS [expected FAIL] HTMLAnchorElement interface: attribute relList
  ▶ Unexpected subtest result in /html/dom/idlharness.https.html?include=HTML.*:
  └ PASS [expected FAIL] HTMLAreaElement interface: attribute relList


  ▶ Unexpected subtest result in /dom/nodes/attributes.html:
  └ PASS [expected FAIL] Toggling element with inline style should make inline style disappear
  ▶ Unexpected subtest result in /css/cssom/idlharness.html:
  └ PASS [expected FAIL] HTMLElement interface: attribute style

  ▶ Unexpected subtest result in /css/css-fonts/variations/font-style-parsing.html:
  └ PASS [expected FAIL] Font-style (computed): 'oblique' followed by zero degrees is valid
  ▶ Unexpected subtest result in /css/css-fonts/variations/font-style-parsing.html:
  └ PASS [expected FAIL] Font-style (computed): 'oblique' followed by positive angle in degrees is valid
  ▶ Unexpected subtest result in /css/css-fonts/variations/font-style-parsing.html:
  └ PASS [expected FAIL] Font-style (computed): 'oblique' followed by positive angle in radians is valid
  ▶ Unexpected subtest result in /css/css-fonts/variations/font-style-parsing.html:
  └ PASS [expected FAIL] Font-style (computed): 'oblique' followed by positive angle in gradians is valid
  ▶ Unexpected subtest result in /css/css-fonts/variations/font-style-parsing.html:
  └ PASS [expected FAIL] Font-style (computed): 'oblique' followed by positive angle in turns is valid
  ▶ Unexpected subtest result in /css/css-fonts/variations/font-style-parsing.html:
  └ PASS [expected FAIL] Font-style (computed): 'oblique' followed by negative angle is valid
  ▶ Unexpected subtest result in /css/css-fonts/variations/font-style-parsing.html:
  └ PASS [expected FAIL] Font-style (computed): 'oblique' followed by fractional angle is valid
  ▶ Unexpected subtest result in /css/css-fonts/variations/font-style-parsing.html:
  └ PASS [expected FAIL] Font-style (computed): 'oblique' followed by maxumum 90 degree angle is valid
  ▶ Unexpected subtest result in /css/css-fonts/variations/font-style-parsing.html:
  └ PASS [expected FAIL] Font-style (computed): 'oblique' followed by minimum -90 degree angle is valid
  ▶ Unexpected subtest result in /css/css-fonts/variations/font-style-parsing.html:
  └ PASS [expected FAIL] Font-style (computed): 'oblique' followed by positive angle is valid
  ▶ Unexpected subtest result in /css/css-fonts/variations/font-style-parsing.html:
  └ PASS [expected FAIL] Font-style (computed): 'oblique' followed by calc is valid
  ▶ Unexpected subtest result in /css/css-fonts/variations/font-style-parsing.html:
  └ PASS [expected FAIL] Font-style (computed): 'oblique' followed by calc is valid even if it must be clamped (no computation)
  ▶ Unexpected subtest result in /css/css-fonts/variations/font-style-parsing.html:
  └ PASS [expected FAIL] Font-style (computed): 'oblique' followed by calc is valid even if it must be clamped (with computation)
@pshaughn pshaughn force-pushed the pshaughn:putforwards branch from 3b0907c to bc5f9e4 Jan 7, 2020
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Jan 7, 2020

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#21062.
@pshaughn
PutForwards cleanup
Loading status checks…
8a4df2a
@pshaughn pshaughn force-pushed the pshaughn:putforwards branch from bc5f9e4 to 8a4df2a Jan 23, 2020
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Jan 23, 2020

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#21062.
@jdm
Copy link
Member

jdm commented Jan 23, 2020

@bors-servo r=jdm,Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Jan 23, 2020

📌 Commit 8a4df2a has been approved by jdm,Manishearth
@highfive highfive assigned jdm and unassigned Manishearth Jan 23, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Jan 23, 2020

⌛ Testing commit 8a4df2a with merge dec6d41...
bors-servo added a commit that referenced this pull request Jan 23, 2020
@bors-servo
Auto merge of #25450 - pshaughn:putforwards, r=jdm,Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
dec6d41 
Add PutForwards to implemented attributes that lacked it

Added PutForwards to three relLists and one style. The style already had a test; I added tests for relLists, including one relList that we have commented out right now.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes advance #9990 to be caught up with the attributes we have so far; many unimplemented attributes will need PutForwards when implemented.

<!-- Either: -->
- [X] There are tests for these changes OR

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 23, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Jan 23, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jan 23, 2020

⌛ Testing commit 8a4df2a with merge 8bc54fd...
bors-servo added a commit that referenced this pull request Jan 23, 2020
@bors-servo
Auto merge of #25450 - pshaughn:putforwards, r=jdm,Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8bc54fd 
Add PutForwards to implemented attributes that lacked it

Added PutForwards to three relLists and one style. The style already had a test; I added tests for relLists, including one relList that we have commented out right now.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes advance #9990 to be caught up with the attributes we have so far; many unimplemented attributes will need PutForwards when implemented.

<!-- Either: -->
- [X] There are tests for these changes OR

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 23, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Jan 23, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jan 23, 2020

⌛ Testing commit 8a4df2a with merge d0d3aaa...
bors-servo added a commit that referenced this pull request Jan 23, 2020
@bors-servo
Auto merge of #25450 - pshaughn:putforwards, r=jdm,Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d0d3aaa 
Add PutForwards to implemented attributes that lacked it

Added PutForwards to three relLists and one style. The style already had a test; I added tests for relLists, including one relList that we have commented out right now.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes advance #9990 to be caught up with the attributes we have so far; many unimplemented attributes will need PutForwards when implemented.

<!-- Either: -->
- [X] There are tests for these changes OR

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 23, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm,Manishearth
Pushing d0d3aaa to master...
@bors-servo bors-servo merged commit 8a4df2a into servo:master Jan 23, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Jan 23, 2020
Merged
4 of 4 tasks complete
@pshaughn pshaughn mentioned this pull request Jan 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@pshaughn @highfive @servo-wpt-sync @Manishearth @bors-servo @jdm @paulrouget
You can’t perform that action at this time.