Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRun adopt as part of insert #25460
Closed
Run adopt as part of insert #25460
Conversation
highfive
commented
Jan 7, 2020
|
Heads up! This PR modifies the following files:
|
highfive
commented
Jan 7, 2020
| if fragment.get_host().is_some() { | ||
| // Spec text doesn't actually say what to return, | ||
| // but IDL doesn't allow null, and | ||
| // returning the node itself seems to be what's expected |
This comment has been minimized.
This comment has been minimized.
|
Given whatwg/dom#813 (comment), perhaps we should hold off on this work until it settles in spec land. |
|
That makes sense. |
|
whatwg/dom#819 hasn't landed yet but whatwg/dom#813 is still unresolved, so if adopt is going to be moved, it will probably be in a different enough way to require completely different code changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pshaughn commentedJan 7, 2020
Changes of whatwg/dom#754 are reflected, but we mostly aren't passing the associated tests. In many cases this is because we don't actually have the shadow DOM functionality that makes this behavior relevant, but that's not all that's being tested and there is probably some other missing piece.
It might make sense to merge this (assuming it passes CI) and open another issue investigating the failures?
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors