Add input mocking, input sources change event #25463

Manishearth · 2020-01-08T13:38:46Z

Depends on servo/webxr#118

Also fixes some bugs I found.

Wanted to finish and merge this before I started on hit testing since the transient hit test stuff might have overlap.

There are a bunch of missing mock pieces that I'll probably do in a separate PR.

Still need to run tests.

Some things I skipped:

Doing handedness/target ray setting: See immersive-web/webxr-test-api#46 , this would require making our impl support these changing
Handling button initial state: Would require some mock changes, but I ran out of time
Handling profiles/etc: We don't yet have impl support for these

r? @jdm

highfive · 2020-01-08T13:38:53Z

Heads up! This PR modifies the following files:

@asajeffrey: components/script/dom/webidls/FakeXRInputController.webidl, components/script/dom/webidls/XRSession.webidl, components/script/dom/mod.rs, components/script/dom/webidls/XRInputSourcesChangeEvent.webidl, components/script/dom/xrinputsourceschangeevent.rs and 8 more
@KiChjang: components/script/dom/webidls/FakeXRInputController.webidl, components/script/dom/webidls/XRSession.webidl, components/script/dom/mod.rs, components/script/dom/webidls/XRInputSourcesChangeEvent.webidl, components/script/dom/xrinputsourceschangeevent.rs and 8 more

highfive · 2020-01-08T13:38:55Z

Warning

These commits modify unsafe code. Please review it carefully!
These commits modify script code, but no tests are modified. Please consider adding a test!

Manishearth · 2020-01-08T14:31:06Z

components/script/dom/xrinputsourceschangeevent.rs

+        // let cx = global.get_cx();
+        // unsafe {
+        //     rooted!(in(*cx) let mut added_val = UndefinedValue());
+        //     added.to_jsval(*cx, added_val.handle_mut());


Annoyingly, to_jsval() here throws a segfault at this line:

https://github.com/servo/mozjs/blob/a2957207f4b296f9ecd207d453224aafa3bd1e86/mozjs/js/src/builtin/Array.cpp#L4032

I've verified that cx is non null. Am I missing something?

servo-wpt-sync · 2020-01-08T14:31:37Z

Opened new PR for upstreamable changes.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#21085.

Manishearth · 2020-01-08T14:40:37Z

Ready to land once servo/webxr#118 does

servo-wpt-sync · 2020-01-08T14:41:49Z

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#21085.


        Update webxr


        Add SimulateVisibilityChange()

servo-wpt-sync · 2020-01-08T18:06:54Z

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#21085.

asajeffrey

LGTM, just some minor nits. r=me assuming the segvs have been fixed!

components/script/dom/fakexrdevice.rs

asajeffrey · 2020-01-08T18:09:35Z

components/script/dom/webidls/XRInputSource.webidl

@@ -19,7 +19,7 @@ enum XRTargetRayMode {
 [SecureContext, Exposed=Window, Pref="dom.webxr.enabled"]
 interface XRInputSource {
  readonly attribute XRHandedness handedness;
-  // [SameObject] readonly attribute XRTargetRayMode targetRayMode;
+  readonly attribute XRTargetRayMode targetRayMode;


Why no [SameObject]?

Can't SameObject enums. I believe this was fixed upstream in the spec, we just never updated the commented webidl.

Manishearth · 2020-01-08T18:16:33Z

@bors-servo r=asajeffrey

bors-servo · 2020-01-08T18:16:34Z

📌 Commit a5ffd2e has been approved by asajeffrey

servo-wpt-sync · 2020-01-08T18:16:37Z

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#21085.

bors-servo · 2020-01-09T01:44:56Z

⌛ Testing commit a5ffd2e with merge 1ad9c4d...


        Auto merge of #25463 - Manishearth:input-mocking, r=asajeffrey

@jdm

Add input mocking, input sources change event Depends on servo/webxr#118 Also fixes some bugs I found. Wanted to finish and merge this before I started on hit testing since the transient hit test stuff might have overlap. There are a bunch of missing mock pieces that I'll probably do in a separate PR. Still need to run tests. Some things I skipped: - Doing handedness/target ray setting: See immersive-web/webxr-test-api#46 , this would require making our impl support these changing - Handling button initial state: Would require some mock changes, but I ran out of time - Handling profiles/etc: We don't yet have impl support for these r? @jdm

bors-servo · 2020-01-09T01:46:25Z

💔 Test failed - status-taskcluster

jdm · 2020-01-09T02:04:18Z

./components/script/dom/webidls/FakeXRInputController.webidl:53: no newline at EOF

jdm · 2020-01-09T04:20:03Z

@bors-servo retry

bors-servo · 2020-01-09T04:33:14Z

⌛ Testing commit 94e8ce5 with merge 52337c7...


        Auto merge of #25463 - Manishearth:input-mocking, r=asajeffrey

@jdm

Add input mocking, input sources change event Depends on servo/webxr#118 Also fixes some bugs I found. Wanted to finish and merge this before I started on hit testing since the transient hit test stuff might have overlap. There are a bunch of missing mock pieces that I'll probably do in a separate PR. Still need to run tests. Some things I skipped: - Doing handedness/target ray setting: See immersive-web/webxr-test-api#46 , this would require making our impl support these changing - Handling button initial state: Would require some mock changes, but I ran out of time - Handling profiles/etc: We don't yet have impl support for these r? @jdm

bors-servo · 2020-01-09T05:15:17Z

💔 Test failed - status-taskcluster

Manishearth · 2020-01-09T06:06:47Z

@bors-servo retry

#24726

1 unexpected results that are NOT known-intermittents:
  ▶ FAIL [expected PASS] /css/CSS2/fonts/font-weight-applies-to-008.xht
  │   → /css/CSS2/fonts/font-weight-applies-to-008.xht 54a9df64f1476dd12020019d7cf22ac34d727bc0
  │   → /css/reference/pass_if_filler_text_match_bold.xht 68ca2ea769567706593ec6c195cb80a02c91b5a2
  └   → Screenshot is solid color 0xFFFFFF for /css/CSS2/fonts/font-weight-applies-to-008.xht

bors-servo · 2020-01-09T06:06:53Z

⌛ Testing commit 94e8ce5 with merge 2a742e7...


        Auto merge of #25463 - Manishearth:input-mocking, r=asajeffrey

@jdm

Add input mocking, input sources change event Depends on servo/webxr#118 Also fixes some bugs I found. Wanted to finish and merge this before I started on hit testing since the transient hit test stuff might have overlap. There are a bunch of missing mock pieces that I'll probably do in a separate PR. Still need to run tests. Some things I skipped: - Doing handedness/target ray setting: See immersive-web/webxr-test-api#46 , this would require making our impl support these changing - Handling button initial state: Would require some mock changes, but I ran out of time - Handling profiles/etc: We don't yet have impl support for these r? @jdm

bors-servo · 2020-01-09T06:25:20Z

💔 Test failed - status-taskcluster

Manishearth · 2020-01-09T06:28:56Z

@bors-servo retry

  ▶ FAIL [expected PASS] /css/CSS2/css1/c16-descendant-002.xht
  │   → /css/CSS2/css1/c16-descendant-002.xht 54a9df64f1476dd12020019d7cf22ac34d727bc0
  │   → /css/CSS2/reference/ref-this-text-should-be-green.xht cc1047e1c7ff45f6ce371b86003daf56e31e4f67
  └   → Screenshot is solid color 0xFFFFFF for /css/CSS2/css1/c16-descendant-002.xht
  ▶ FAIL [expected PASS] /_mozilla/css/transform_3d.html
  │   → /_mozilla/css/transform_3d.html 54a9df64f1476dd12020019d7cf22ac34d727bc0
  │   → /_mozilla/css/transform_3d_ref.html fc1036f05dcdf401b928df32bbf403df76bb1b9c
  └   → Screenshot is solid color 0xFFFFFF for /_mozilla/css/transform_3d.html

bors-servo · 2020-01-09T06:29:39Z

⌛ Testing commit 94e8ce5 with merge a35879e...


        Auto merge of #25463 - Manishearth:input-mocking, r=asajeffrey

@jdm

Add input mocking, input sources change event Depends on servo/webxr#118 Also fixes some bugs I found. Wanted to finish and merge this before I started on hit testing since the transient hit test stuff might have overlap. There are a bunch of missing mock pieces that I'll probably do in a separate PR. Still need to run tests. Some things I skipped: - Doing handedness/target ray setting: See immersive-web/webxr-test-api#46 , this would require making our impl support these changing - Handling button initial state: Would require some mock changes, but I ran out of time - Handling profiles/etc: We don't yet have impl support for these r? @jdm

bors-servo · 2020-01-09T06:45:35Z

💔 Test failed - status-taskcluster

Manishearth · 2020-01-09T06:54:47Z

@bors-servo retry

#24726 again

bors-servo · 2020-01-09T07:45:53Z

⌛ Testing commit 94e8ce5 with merge dbee7f7...


        Auto merge of #25463 - Manishearth:input-mocking, r=asajeffrey

@jdm

Add input mocking, input sources change event Depends on servo/webxr#118 Also fixes some bugs I found. Wanted to finish and merge this before I started on hit testing since the transient hit test stuff might have overlap. There are a bunch of missing mock pieces that I'll probably do in a separate PR. Still need to run tests. Some things I skipped: - Doing handedness/target ray setting: See immersive-web/webxr-test-api#46 , this would require making our impl support these changing - Handling button initial state: Would require some mock changes, but I ran out of time - Handling profiles/etc: We don't yet have impl support for these r? @jdm

bors-servo · 2020-01-09T08:06:28Z

☀️ Test successful - status-taskcluster
Approved by: asajeffrey
Pushing dbee7f7 to master...

highfive assigned jdm Jan 8, 2020

highfive added the S-awaiting-review label Jan 8, 2020

Manishearth force-pushed the Manishearth:input-mocking branch from 1f6b191 to 0732658 Jan 8, 2020

Manishearth reviewed Jan 8, 2020

View changes

servo-wpt-sync mentioned this pull request Jan 8, 2020

Add input mocking, input sources change event web-platform-tests/wpt#21085

Merged

Manishearth force-pushed the Manishearth:input-mocking branch from 0732658 to 5ab4a27 Jan 8, 2020

Manishearth marked this pull request as ready for review Jan 8, 2020

Manishearth added 2 commits Jan 8, 2020

Update webxr

6a21983

Add SimulateVisibilityChange()

9ecb13d

Manishearth force-pushed the Manishearth:input-mocking branch from 5ab4a27 to 794eac5 Jan 8, 2020

asajeffrey approved these changes Jan 8, 2020

View changes

highfive assigned asajeffrey and unassigned jdm Jan 8, 2020

highfive added S-awaiting-merge and removed S-awaiting-review labels Jan 8, 2020

highfive added S-tests-failed and removed S-awaiting-merge labels Jan 9, 2020

highfive added S-awaiting-merge and removed S-tests-failed labels Jan 9, 2020

highfive added S-tests-failed and removed S-awaiting-merge labels Jan 9, 2020

highfive added S-awaiting-merge and removed S-tests-failed labels Jan 9, 2020

Manishearth mentioned this pull request Jan 9, 2020

Use dom and new_inherited in (extendable)messageevent #25467

Merged

0 of 5 tasks complete

highfive added S-tests-failed and removed S-awaiting-merge labels Jan 9, 2020

highfive added S-awaiting-merge and removed S-tests-failed labels Jan 9, 2020

bors-servo merged commit 94e8ce5 into servo:master Jan 9, 2020
2 checks passed

2 checks passed

Community-TC (pull_request) TaskGroup: success
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Jan 9, 2020

Manishearth mentioned this pull request Jan 13, 2020

Support changing input sources in WebXR #24191

Closed

servo / servo

Add input mocking, input sources change event #25463

Add input mocking, input sources change event #25463

Manishearth commented Jan 8, 2020 •

edited

highfive commented Jan 8, 2020

highfive commented Jan 8, 2020

This comment has been minimized.

servo-wpt-sync commented Jan 8, 2020

Manishearth commented Jan 8, 2020

servo-wpt-sync commented Jan 8, 2020

servo-wpt-sync commented Jan 8, 2020

asajeffrey left a comment

This comment has been minimized.

This comment has been minimized.

Manishearth commented Jan 8, 2020

bors-servo commented Jan 8, 2020

servo-wpt-sync commented Jan 8, 2020

bors-servo commented Jan 9, 2020

bors-servo commented Jan 9, 2020

jdm commented Jan 9, 2020

jdm commented Jan 9, 2020

bors-servo commented Jan 9, 2020

bors-servo commented Jan 9, 2020

Manishearth commented Jan 9, 2020

bors-servo commented Jan 9, 2020

bors-servo commented Jan 9, 2020

Manishearth commented Jan 9, 2020

bors-servo commented Jan 9, 2020

bors-servo commented Jan 9, 2020

Manishearth commented Jan 9, 2020

bors-servo commented Jan 9, 2020

bors-servo commented Jan 9, 2020

servo / servo

Join GitHub today

Add input mocking, input sources change event #25463

Add input mocking, input sources change event #25463

Conversation

Manishearth commented Jan 8, 2020 • edited

highfive commented Jan 8, 2020

highfive commented Jan 8, 2020

This comment has been minimized.

Manishearth Jan 8, 2020

servo-wpt-sync commented Jan 8, 2020

Manishearth commented Jan 8, 2020

servo-wpt-sync commented Jan 8, 2020

servo-wpt-sync commented Jan 8, 2020

asajeffrey left a comment

This comment has been minimized.

asajeffrey Jan 8, 2020

This comment has been minimized.

Manishearth Jan 8, 2020

Manishearth commented Jan 8, 2020

bors-servo commented Jan 8, 2020

servo-wpt-sync commented Jan 8, 2020

bors-servo commented Jan 9, 2020

bors-servo commented Jan 9, 2020

jdm commented Jan 9, 2020

jdm commented Jan 9, 2020

bors-servo commented Jan 9, 2020

bors-servo commented Jan 9, 2020

Manishearth commented Jan 9, 2020

bors-servo commented Jan 9, 2020

bors-servo commented Jan 9, 2020

Manishearth commented Jan 9, 2020

bors-servo commented Jan 9, 2020

bors-servo commented Jan 9, 2020

Manishearth commented Jan 9, 2020

bors-servo commented Jan 9, 2020

bors-servo commented Jan 9, 2020

Manishearth commented Jan 8, 2020 •

edited