Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor display list creation, preparing for background-image #25475

Merged
merged 6 commits into from Jan 9, 2020
Merged

Refactor display list creation, preparing for background-image #25475

merged 6 commits into from Jan 9, 2020
+179 −124

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Jan 9, 2020

backgound-image itself will require more plumbing to get an image cache in layout_thread_2020. This can land in the mean time.
SimonSapin added 6 commits Oct 24, 2019
@SimonSapin
Parse `-moz-image-rect()` and `-moz-element()` only in Gecko
062c187
@SimonSapin
Use the is_contentful field of DisplayListBuilder
53fc614
@SimonSapin
Move box fragment hit testing to a dedicated display item
c495b5a
@SimonSapin
Introduce BuilderForBoxFragment
75e1f11
@SimonSapin
Account for border-radius in hit-testing
12c18a0
@SimonSapin
Simplify `CommonItemProperties` construction
Loading status checks…
87b7998
@SimonSapin SimonSapin added this to In progress in Layout 2020 via automation Jan 9, 2020
@highfive
Copy link

highfive commented Jan 9, 2020

Heads up! This PR modifies the following files:

  • @emilio: components/style/values/specified/image.rs, components/style/values/computed/image.rs, components/layout/display_list/builder.rs, components/style/values/generics/image.rs, components/style/traversal.rs
@highfive
Copy link

highfive commented Jan 9, 2020

warning Warning warning

  • These commits modify style and layout code, but no tests are modified. Please consider adding a test!
@SimonSapin
Copy link
Member Author

SimonSapin commented Jan 9, 2020

r? @nox
CC @mrobinson
@highfive highfive assigned nox and unassigned asajeffrey Jan 9, 2020
@nox
Copy link
Member

nox commented Jan 9, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 9, 2020

📌 Commit 87b7998 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Jan 9, 2020

⌛ Testing commit 87b7998 with merge 3628a48...
bors-servo added a commit that referenced this pull request Jan 9, 2020
@bors-servo
Auto merge of #25475 - servo:background-image, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3628a48 
Refactor display list creation, preparing for background-image

`backgound-image` itself will require more plumbing to get an image cache in `layout_thread_2020`. This can land in the mean time.
@bors-servo
Copy link
Contributor

bors-servo commented Jan 9, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Jan 9, 2020

@bors-servo retry
bors-servo added a commit that referenced this pull request Jan 9, 2020
@bors-servo
Auto merge of #25475 - servo:background-image, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c6192dc 
Refactor display list creation, preparing for background-image

`backgound-image` itself will require more plumbing to get an image cache in `layout_thread_2020`. This can land in the mean time.
@bors-servo
Copy link
Contributor

bors-servo commented Jan 9, 2020

⌛ Testing commit 87b7998 with merge c6192dc...
@bors-servo
Copy link
Contributor

bors-servo commented Jan 9, 2020

☀️ Test successful - status-taskcluster
Approved by: nox
Pushing c6192dc to master...
@bors-servo bors-servo merged commit 87b7998 into master Jan 9, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Layout 2020 automation moved this from In progress to Merged / resolved Jan 9, 2020
@bors-servo bors-servo deleted the background-image branch Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
A-layout/2020
Projects
Layout 2020
  
Merged / resolved
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@SimonSapin @highfive @nox @bors-servo @jdm @asajeffrey
You can’t perform that action at this time.