Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSimplify and fix iteration over radio button group #25490
Merged
+49
−53
Conversation
highfive
commented
Jan 11, 2020
|
Heads up! This PR modifies the following files:
|
highfive
commented
Jan 11, 2020
|
|
|
There is a test for orphan trees in |
|
@bors-servo try=wpt |
bors-servo
added a commit
that referenced
this pull request
Jan 11, 2020
Simplify and fix iteration over radio button group - Code for iterating over radio button group elements has been extracted to `radio_group_iter` - `in_same_group` now checks if elements are in the same tree - `radio_group_name` returns `None` if name is empty - Radio buttons now group together in orphan trees (#25486) --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #25486 - [ ] There are tests for these changes
|
|
|
@Manishearth Review ping. |
|
@bors-servo r+ Thanks! |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 23, 2020
Simplify and fix iteration over radio button group - Code for iterating over radio button group elements has been extracted to `radio_group_iter` - `in_same_group` now checks if elements are in the same tree - `radio_group_name` returns `None` if name is empty - Radio buttons now group together in orphan trees (#25486) --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #25486 - [ ] There are tests for these changes
|
|
|
@bors-servo retry looks like the solid color intermittents again? cc @jdm |
bors-servo
added a commit
that referenced
this pull request
Jan 23, 2020
Simplify and fix iteration over radio button group - Code for iterating over radio button group elements has been extracted to `radio_group_iter` - `in_same_group` now checks if elements are in the same tree - `radio_group_name` returns `None` if name is empty - Radio buttons now group together in orphan trees (#25486) --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #25486 - [ ] There are tests for these changes
|
|
|
@bors-servo retry random timeouts? |
bors-servo
added a commit
that referenced
this pull request
Jan 23, 2020
Simplify and fix iteration over radio button group - Code for iterating over radio button group elements has been extracted to `radio_group_iter` - `in_same_group` now checks if elements are in the same tree - `radio_group_name` returns `None` if name is empty - Radio buttons now group together in orphan trees (#25486) --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #25486 - [ ] There are tests for these changes
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
teapotd commentedJan 11, 2020
radio_group_iterin_same_groupnow checks if elements are in the same treeradio_group_namereturnsNoneif name is empty./mach build -ddoes not report any errors./mach test-tidydoes not report any errors