Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: build Linux amd64 --media-stack=dummy #25495

Merged
merged 1 commit into from Jan 14, 2020
Merged

CI: build Linux amd64 --media-stack=dummy #25495

merged 1 commit into from Jan 14, 2020

Conversation

@tuncer
Copy link
Contributor

tuncer commented Jan 12, 2020 •
edited

Include --media-stack=dummy in CI, as discussed in #24829.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • There are tests for these changes OR
  • These changes do not require tests because it's build infra
@tuncer tuncer mentioned this pull request Jan 12, 2020
Closed
3 of 3 tasks complete
@jdm
Copy link
Member

jdm commented Jan 13, 2020

Rather than a separate build job that happens once per day, please add a --dev build with the dummy media stack to the list at

servo/etc/taskcluster/decision_task.py

Line 212 in 904fcb4

python3 ./mach build --dev -p servo-gst-plugin
.
@tuncer
Copy link
Contributor Author

tuncer commented Jan 14, 2020

Done
@jdm
Copy link
Member

jdm commented Jan 14, 2020

Looks good! Please squash the commits into one.
@tuncer
CI: build Linux amd64 --media-stack=dummy
Loading status checks…
f2fedd8
@tuncer
Copy link
Contributor Author

tuncer commented Jan 14, 2020

Collapsed commits
@tuncer
Copy link
Contributor Author

tuncer commented Jan 14, 2020

Before we merge this: is there a need to make sure there's no gstreamer in the build env, before executing the task? I mean, it's run after build --dev -p servo-gst-plugin, so I assume gstreamer is installed, in constrast to linux_tidy_unit_untrusted, where we first bootstrap gstreamer. That said, since we're explicitly selecting the dummy backend, it shouldn't matter. Thoughts?
@jdm
Copy link
Member

jdm commented Jan 14, 2020

I don't think it's worth the effort to build it in an environment that doesn't have gstreamer available.
@jdm
Copy link
Member

jdm commented Jan 14, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 14, 2020

📌 Commit f2fedd8 has been approved by jdm
bors-servo added a commit that referenced this pull request Jan 14, 2020
@bors-servo
Auto merge of #25495 - tuncer:ci-media-dummy, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
16d9bba 
CI: build Linux amd64 --media-stack=dummy

<!-- Please describe your changes on the following line: -->
Include `--media-stack=dummy` in CI, as discussed in #24829.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because it's build infra

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 14, 2020

⌛ Testing commit f2fedd8 with merge 16d9bba...
@bors-servo
Copy link
Contributor

bors-servo commented Jan 14, 2020

💔 Test failed - status-taskcluster
@tuncer
Copy link
Contributor Author

tuncer commented Jan 14, 2020

Test failure in macOS x64: WPT chunk 02 / 20 looks unrelated:

UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 58:
    ordinal not in range(128)
[...]task_1579029530/repo/python/servo/testing_commands.py",
    line 575, in filter_intermittents
@jdm
Copy link
Member

jdm commented Jan 14, 2020

@bors-servo retry
bors-servo added a commit that referenced this pull request Jan 14, 2020
@bors-servo
Auto merge of #25495 - tuncer:ci-media-dummy, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f2d2c7d 
CI: build Linux amd64 --media-stack=dummy

<!-- Please describe your changes on the following line: -->
Include `--media-stack=dummy` in CI, as discussed in #24829.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because it's build infra

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 14, 2020

⌛ Testing commit f2fedd8 with merge f2d2c7d...
@bors-servo
Copy link
Contributor

bors-servo commented Jan 14, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing f2d2c7d to master...
@bors-servo bors-servo merged commit f2fedd8 into servo:master Jan 14, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@tuncer tuncer deleted the tuncer:ci-media-dummy branch Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@tuncer @jdm @bors-servo @highfive
You can’t perform that action at this time.