Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement dirname support for form element #25499

Merged
merged 10 commits into from Feb 25, 2020
Merged

Implement dirname support for form element #25499

merged 10 commits into from Feb 25, 2020

Conversation

@NeverHappened
Copy link
Contributor

NeverHappened commented Jan 12, 2020 •
edited

Added support for dirname in input on form submit
Added Dir getter / setter for HTMLElement
NOT YET Added get directionality according to https://html.spec.whatwg.org/multipage/dom.html#the-directionality

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #25379 (GitHub issue number if applicable)
@highfive
Copy link

highfive commented Jan 12, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/htmlformelement.rs, components/script/dom/webidls/HTMLElement.webidl, components/script/dom/htmlelement.rs
  • @KiChjang: components/script/dom/htmlformelement.rs, components/script/dom/webidls/HTMLElement.webidl, components/script/dom/htmlelement.rs
@highfive
Copy link

highfive commented Jan 12, 2020

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@NeverHappened NeverHappened force-pushed the NeverHappened:implement-form-dirname branch 2 times, most recently from ce8c175 to fdd63e5 Jan 20, 2020
@NeverHappened
Copy link
Contributor Author

NeverHappened commented Jan 26, 2020

Does iframes in Servo work? It seems that wpt test doesn't work althrough form tries to navigate to correct url
@pshaughn
Copy link
Member

pshaughn commented Jan 26, 2020

Iframes work at a basic level, but the sequence of steps when they load is out of order and sometimes things in an iframe are executed earlier or later than the scripts expect. You might need to try modified versions of the test to figure out what functionality is or isn't happening.
@NeverHappened NeverHappened force-pushed the NeverHappened:implement-form-dirname branch from fdd63e5 to b4b578d Jan 30, 2020
@servo-wpt-sync servo-wpt-sync mentioned this pull request Jan 30, 2020
Closed
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Jan 30, 2020

Opened new PR for upstreamable changes.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#21520.
@NeverHappened NeverHappened force-pushed the NeverHappened:implement-form-dirname branch from b4b578d to 0cbfdda Jan 30, 2020
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Jan 30, 2020

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#21520.
@NeverHappened NeverHappened requested a review from jdm Feb 2, 2020
@pshaughn
pshaughn reviewed Feb 2, 2020
View changes
...html/semantics/forms/attributes-common-to-form-controls/dirname-ltr.html Outdated Show resolved Hide resolved
@NeverHappened NeverHappened force-pushed the NeverHappened:implement-form-dirname branch from 0cbfdda to f5c086b Feb 3, 2020
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Feb 3, 2020

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#21520.
@jdm jdm added the S-needs-rebase label Feb 10, 2020
@jdm jdm assigned jdm and unassigned SimonSapin Feb 10, 2020
@jdm
jdm requested changes Feb 11, 2020
View changes
Copy link
Member

jdm left a comment

Good start!
components/script/dom/element.rs Outdated Show resolved Hide resolved
components/script/dom/element.rs Outdated Show resolved Hide resolved
components/script/dom/element.rs Outdated Show resolved Hide resolved
components/script/dom/element.rs Outdated Show resolved Hide resolved
components/script/dom/element.rs Outdated Show resolved Hide resolved
components/script/dom/htmlinputelement.rs Outdated Show resolved Hide resolved
@jdm jdm mentioned this pull request Feb 11, 2020
Closed
@NeverHappened NeverHappened force-pushed the NeverHappened:implement-form-dirname branch from f5c086b to 6b116f6 Feb 15, 2020
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Feb 15, 2020

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#21520.
@NeverHappened
Copy link
Contributor Author

NeverHappened commented Feb 15, 2020

@pshaughn Is it good to write additional wpt tests?
A little bit confused, because they're somehow linked to base wpt tests, and they try to sync there web-platform-tests/wpt#21520
@NeverHappened
Add special case directionality of phone input
6188116
@NeverHappened
Implement step 5.13 for dirname correctly
ab2aeb6
@NeverHappened
Use map_or and fix manifest
25c5a4c
@NeverHappened
Remove FAIL expectations for dir and dirname attributes (not all of t…
Loading status checks…
50b4956 
…hem)
@NeverHappened NeverHappened force-pushed the NeverHappened:implement-form-dirname branch from 669a585 to 50b4956 Feb 24, 2020
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Feb 24, 2020

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#21932.
@jdm
Copy link
Member

jdm commented Feb 24, 2020

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Feb 24, 2020

⌛ Trying commit 50b4956 with merge aa00a58...
bors-servo added a commit that referenced this pull request Feb 24, 2020
@bors-servo
Auto merge of #25499 - NeverHappened:implement-form-dirname, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
aa00a58 
Implement dirname support for form element

Added support for dirname in input on form submit
Added Dir getter / setter for HTMLElement
NOT YET Added get directionality according to https://html.spec.whatwg.org/multipage/dom.html#the-directionality

- [X] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #25379 (GitHub issue number if applicable)
@bors-servo
Copy link
Contributor

bors-servo commented Feb 24, 2020

☀️ Test successful - status-taskcluster
State: approved= try=True
@jdm
Copy link
Member

jdm commented Feb 24, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Feb 24, 2020

📌 Commit 50b4956 has been approved by jdm
bors-servo added a commit that referenced this pull request Feb 25, 2020
@bors-servo
Auto merge of #25499 - NeverHappened:implement-form-dirname, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
887afe4 
Implement dirname support for form element

Added support for dirname in input on form submit
Added Dir getter / setter for HTMLElement
NOT YET Added get directionality according to https://html.spec.whatwg.org/multipage/dom.html#the-directionality

- [X] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #25379 (GitHub issue number if applicable)
@bors-servo
Copy link
Contributor

bors-servo commented Feb 25, 2020

⌛ Testing commit 50b4956 with merge 887afe4...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 25, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Feb 25, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 25, 2020

⌛ Testing commit 50b4956 with merge 145c89a...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 25, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 145c89a to master...
@bors-servo bors-servo merged commit 145c89a into servo:master Feb 25, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@NeverHappened NeverHappened deleted the NeverHappened:implement-form-dirname branch Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pshaughn pshaughn

@jdm jdm

Assignees

@jdm jdm

Labels
S-fails-tidy
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Implement form dirname
7 participants
@NeverHappened @highfive @pshaughn @servo-wpt-sync @jdm @bors-servo @SimonSapin
You can’t perform that action at this time.