Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support features in webxr #25504

Merged
merged 7 commits into from Jan 22, 2020
Merged

Support features in webxr #25504

merged 7 commits into from Jan 22, 2020
+222 −93

Conversation

@Manishearth
Copy link
Member

Manishearth commented Jan 13, 2020 •
edited

Based on servo/webxr#119

Todo:

  • gate reference space creation on feature presence
  • Fix the features_deviceSupport test to correctly use simulateUserActivation

Fixes #24196, #24270
r? @jdm @asajeffrey
@highfive
Copy link

highfive commented Jan 13, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webidls/FakeXRInputController.webidl, components/script/dom/xrtest.rs, components/script/dom/webidls/XRTest.webidl, components/script/dom/xrinputsourceschangeevent.rs, components/script/dom/xrinputsource.rs and 7 more
  • @KiChjang: components/script/dom/webidls/FakeXRInputController.webidl, components/script/dom/xrtest.rs, components/script/dom/webidls/XRTest.webidl, components/script/dom/xrinputsourceschangeevent.rs, components/script/dom/xrinputsource.rs and 7 more
@highfive
Copy link

highfive commented Jan 13, 2020

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@Manishearth Manishearth mentioned this pull request Jan 13, 2020
Merged
@Manishearth Manishearth force-pushed the Manishearth:features branch from e0d4dcf to 157d8dd Jan 13, 2020
@servo-wpt-sync servo-wpt-sync mentioned this pull request Jan 14, 2020
Merged
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Jan 14, 2020

Opened new PR for upstreamable changes.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#21159.
@Manishearth Manishearth changed the title WIP: support features in webxr Support features in webxr Jan 14, 2020
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Jan 14, 2020

PR title changed; changed existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#21159.
@Manishearth Manishearth marked this pull request as ready for review Jan 14, 2020
@Manishearth
Copy link
Member Author

Manishearth commented Jan 14, 2020

Ready for review.
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Jan 14, 2020

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#21159.
@jdm
Copy link
Member

jdm commented Jan 14, 2020 

{"path": "webxr/xrSession_features_deviceSupport.https.html", "message": "Whitespace at EOL", "lineno": 34, "rule": "TRAILING WHITESPACE"}
{"path": "webxr/xrSession_features_deviceSupport.https.html", "message": "Whitespace at EOL", "lineno": 52, "rule": "TRAILING WHITESPACE"}
{"path": "webxr/resources/webxr_util.js", "message": "Whitespace at EOL", "lineno": 105, "rule": "TRAILING WHITESPACE"}
@Manishearth Manishearth force-pushed the Manishearth:features branch from 5552288 to 6ba4fbb Jan 15, 2020
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Jan 15, 2020

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#21159.
@Manishearth Manishearth force-pushed the Manishearth:features branch from 6ba4fbb to f782bf9 Jan 15, 2020
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Jan 15, 2020

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#21159.
@jdm
Copy link
Member

jdm commented Jan 15, 2020

r? @asajeffrey
@highfive highfive assigned asajeffrey and unassigned jdm Jan 15, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Jan 17, 2020

☔ The latest upstream changes (presumably #25544) made this pull request unmergeable. Please resolve the merge conflicts.
@asajeffrey
asajeffrey approved these changes Jan 21, 2020
View changes
Copy link
Member

asajeffrey left a comment

LGTM once we've landed the webxr PR.
components/script/dom/fakexrdevice.rs Outdated Show resolved Hide resolved
@Manishearth Manishearth force-pushed the Manishearth:features branch from f782bf9 to fb01e6c Jan 21, 2020
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Jan 21, 2020

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#21159.
bors-servo added a commit to servo/webxr that referenced this pull request Jan 21, 2020
@bors-servo
Auto merge of #119 - Manishearth:features, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9ef71da 
Support for features, profiles, and mocking ray mode/handedness

r? @jdm @asajeffrey

Servo side: servo/servo#25504
bors-servo added a commit to servo/webxr that referenced this pull request Jan 21, 2020
@bors-servo
Auto merge of #119 - Manishearth:features, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
33072cb 
Support for features, profiles, and mocking ray mode/handedness

r? @jdm @asajeffrey

Servo side: servo/servo#25504
Manishearth added 2 commits Jan 13, 2020
@Manishearth
Update webxr
e9221e6
@Manishearth
Handle SetTargetRayMode and SetHandedness
9c34a65
@Manishearth
Correctly unset pending flag
535e05f
@Manishearth Manishearth force-pushed the Manishearth:features branch from fb01e6c to 8a9283d Jan 21, 2020
@Manishearth
Copy link
Member Author

Manishearth commented Jan 21, 2020

@bors-servo r=asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented Jan 21, 2020

📌 Commit 8a9283d has been approved by asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented Jan 21, 2020

⌛ Testing commit 8a9283d with merge 963ded8...
bors-servo added a commit that referenced this pull request Jan 21, 2020
@bors-servo
Auto merge of #25504 - Manishearth:features, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
963ded8 
Support features in webxr

Based on servo/webxr#119

Todo:
 - [x] gate reference space creation on feature presence
 - [x] Fix the `features_deviceSupport` test to correctly use simulateUserActivation

Fixes #24196, #24270
r? @jdm @asajeffrey
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Jan 21, 2020

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#21159.
@bors-servo
Copy link
Contributor

bors-servo commented Jan 22, 2020

💔 Test failed - status-taskcluster
Manishearth added 2 commits Jan 14, 2020
@Manishearth
Update xrSession_features_deviceSupport to use new user activations f…
8cc7c51 
…or each session request
@Manishearth
Gate reference space creation on requested features
Loading status checks…
9a04a37
@Manishearth Manishearth force-pushed the Manishearth:features branch from 8a9283d to 9a04a37 Jan 22, 2020
@Manishearth
Copy link
Member Author

Manishearth commented Jan 22, 2020

@bors-servo r=asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented Jan 22, 2020

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
@bors-servo
Copy link
Contributor

bors-servo commented Jan 22, 2020

📌 Commit 9a04a37 has been approved by asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented Jan 22, 2020

⌛ Testing commit 9a04a37 with merge ee3fb92...
bors-servo added a commit that referenced this pull request Jan 22, 2020
@bors-servo
Auto merge of #25504 - Manishearth:features, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ee3fb92 
Support features in webxr

Based on servo/webxr#119

Todo:
 - [x] gate reference space creation on feature presence
 - [x] Fix the `features_deviceSupport` test to correctly use simulateUserActivation

Fixes #24196, #24270
r? @jdm @asajeffrey
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Jan 22, 2020

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#21159.
@bors-servo
Copy link
Contributor

bors-servo commented Jan 22, 2020

☀️ Test successful - status-taskcluster
Approved by: asajeffrey
Pushing ee3fb92 to master...
@bors-servo bors-servo merged commit 9a04a37 into servo:master Jan 22, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@atouchet atouchet mentioned this pull request Jan 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asajeffrey asajeffrey

Assignees

@asajeffrey asajeffrey

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Support input profiles in WebXR
6 participants
@Manishearth @highfive @servo-wpt-sync @jdm @bors-servo @asajeffrey
You can’t perform that action at this time.