Render `background-image: url(…)` #25512

SimonSapin · 2020-01-13T21:14:58Z

… and support most background-* properties.

Still to do:

background-attachment
Gradients


        Enable CSS2 background tests


        Add 2020 expectations for CSS2/background


        Move `OpaqueNode` to `style_traits`


        Copy image-fetching code from Layout 2013


        Pass LayoutContext to DisplayListBuilder


        Add support for some `-Z dump-*` options


        Initial rendering of background-image


        Background positioning with initial values


        Use OnceCell instead of Option


        Add background-clip


        Add background-origin


        Add background-size


        Add background-position


        Don’t paint a zero-size background image


        Add background-repeat


        Add the full background shorthand


        Update WPT expectations

SimonSapin · 2020-01-13T21:15:15Z

r? @nox
@bors-servo try=wpt-2020

bors-servo · 2020-01-13T21:15:20Z

⌛ Trying commit b5042ea with merge fdfaa9f...


        Auto merge of #25512 - servo:background-image, r=<try>

Render `background-image: url(…)` … and support most `background-*` properties. Still to do: * `background-attachment` * Gradients

bors-servo · 2020-01-13T21:39:08Z

☀️ Test successful - status-taskcluster
State: approved= try=True


        Use a non-repeating display item for `background-repeat: no-repeat`


        Re-comment

nox

Nice comments all around.

nox · 2020-01-14T13:33:16Z

components/layout_thread_2020/lib.rs

@@ -553,13 +563,15 @@ impl LayoutThread {
    fn build_layout_context<'a>(
        &'a self,
        guards: StylesheetGuards<'a>,
+        script_initiated_layout: bool,


Maybe an enum, LayoutRequestOrigin or something?

This is copied from components/layout_thread

nox · 2020-01-14T13:33:16Z

components/layout_thread_2020/lib.rs

+        dump_display_list: bool,
+        dump_display_list_json: bool,
+        dump_style_tree: bool,
+        dump_rule_tree: bool,


Such an unethical method. 😂 No nit here though, we don't have time for that.

Yeah it’s pretty bad, but also copied over.

nox · 2020-01-14T13:33:16Z

components/layout_2020/Cargo.toml

@@ -25,6 +25,7 @@ ipc-channel = "0.12"
 libc = "0.2"
 msg = {path = "../msg"}
 net_traits = {path = "../net_traits"}
+once_cell = "1.2.0"


We already use mitochondria, which has an OnceCell, I think.

nox · 2020-01-14T13:33:16Z

components/layout_2020/display_list.rs

@@ -426,7 +426,7 @@ impl<'a> BuilderForBoxFragment<'a> {
            clipping_area_origin: f32,
            clipping_area_size: f32,
            positioning_area_size: f32,
-        ) -> (f32, f32) {
+        ) -> (bool, f32, f32) {


Struct would be nice here.


        Use mitochondria


        Structify a tuple

SimonSapin · 2020-01-17T13:33:58Z

@bors-servo r=nox

bors-servo · 2020-01-17T13:33:59Z

📌 Commit 86c028e has been approved by nox


        Auto merge of #25512 - servo:background-image, r=nox

Render `background-image: url(…)` … and support most `background-*` properties. Still to do: * `background-attachment` * Gradients

bors-servo · 2020-01-17T13:34:08Z

⌛ Testing commit 86c028e with merge ba93475...

bors-servo · 2020-01-17T14:14:39Z

💔 Test failed - status-taskcluster

SimonSapin · 2020-01-17T14:40:28Z

@bors-servo retry

#25523 ?

  ▶ TIMEOUT [expected OK] /html/semantics/forms/the-button-element/button-submit-remove-children-jssubmit.html
  │ 
  │ 
  │ 
  └ 
  ▶ Unexpected subtest result in /html/semantics/forms/the-button-element/button-submit-remove-children-jssubmit.html:
  │ TIMEOUT [expected PASS] This test will pass if a form navigation successfully occurs when clicking a child element of a <button type=submit> element with a onclick event handler which removes the button's child and then calls form.submit().
  └   → Test timed out

bors-servo · 2020-01-17T14:40:35Z

⌛ Testing commit 86c028e with merge 9120257...


        Auto merge of #25512 - servo:background-image, r=nox

Render `background-image: url(…)` … and support most `background-*` properties. Still to do: * `background-attachment` * Gradients

bors-servo · 2020-01-17T15:11:44Z

💔 Test failed - status-taskcluster

SimonSapin · 2020-01-17T15:20:21Z

@bors-servo retry #24622

bors-servo · 2020-01-17T15:52:40Z

⌛ Testing commit 86c028e with merge 1de9290...


        Auto merge of #25512 - servo:background-image, r=nox

Render `background-image: url(…)` … and support most `background-*` properties. Still to do: * `background-attachment` * Gradients

bors-servo · 2020-01-17T16:08:32Z

☀️ Test successful - status-taskcluster
Approved by: nox
Pushing 1de9290 to master...

SimonSapin added 17 commits Jan 13, 2020

Enable CSS2 background tests

f1712e7

Add 2020 expectations for CSS2/background

d988b4c

Move `OpaqueNode` to `style_traits`

cbcf83f

Copy image-fetching code from Layout 2013

c8cbc57

Pass LayoutContext to DisplayListBuilder

40453ad

Add support for some `-Z dump-*` options

d332dfd

Initial rendering of background-image

c6ba6c4

Background positioning with initial values

252877a

Use OnceCell instead of Option

d8ed710

Add background-clip

3874946

Add background-origin

649d3cb

Add background-size

b1dcd5e

Add background-position

c73dc88

Don’t paint a zero-size background image

6e78cdf

Add background-repeat

7c1f233

Add the full background shorthand

2720c05

Update WPT expectations

Loading status checks…

b5042ea

SimonSapin added the A-layout/2020 label Jan 13, 2020

SimonSapin added this to In progress in Layout 2020 via automation Jan 13, 2020

highfive assigned nox Jan 13, 2020

jdm mentioned this pull request Jan 13, 2020

Flex layout is not updated on window resize #20822

Open

SimonSapin added 2 commits Jan 13, 2020

Use a non-repeating display item for `background-repeat: no-repeat`

c72f789

Re-comment

Loading status checks…

cac3286

highfive added the S-awaiting-review label Jan 13, 2020

nox reviewed Jan 14, 2020

View changes

Use mitochondria

0340ac6

Structify a tuple

Loading status checks…

86c028e

highfive added S-awaiting-merge and removed S-awaiting-review labels Jan 17, 2020

highfive added S-tests-failed and removed S-awaiting-merge labels Jan 17, 2020

highfive added S-awaiting-merge and removed S-tests-failed labels Jan 17, 2020

highfive added S-tests-failed and removed S-awaiting-merge labels Jan 17, 2020

highfive added S-awaiting-merge and removed S-tests-failed labels Jan 17, 2020

bors-servo merged commit 86c028e into master Jan 17, 2020
2 checks passed

2 checks passed

Community-TC (pull_request) TaskGroup: success
Details

homu Test successful
Details

Layout 2020 automation moved this from In progress to Merged / resolved Jan 17, 2020

bors-servo deleted the background-image branch Jan 17, 2020

highfive removed the S-awaiting-merge label Jan 17, 2020

servo / servo

Render `background-image: url(…)` #25512

Render `background-image: url(…)` #25512

SimonSapin commented Jan 13, 2020

SimonSapin commented Jan 13, 2020

bors-servo commented Jan 13, 2020

bors-servo commented Jan 13, 2020

nox left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

SimonSapin commented Jan 17, 2020

bors-servo commented Jan 17, 2020

bors-servo commented Jan 17, 2020

bors-servo commented Jan 17, 2020

SimonSapin commented Jan 17, 2020

bors-servo commented Jan 17, 2020

bors-servo commented Jan 17, 2020

SimonSapin commented Jan 17, 2020

bors-servo commented Jan 17, 2020

bors-servo commented Jan 17, 2020

servo / servo

Join GitHub today

Render `background-image: url(…)` #25512

Render `background-image: url(…)` #25512

Conversation

SimonSapin commented Jan 13, 2020

SimonSapin commented Jan 13, 2020

bors-servo commented Jan 13, 2020

bors-servo commented Jan 13, 2020

nox left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

SimonSapin commented Jan 17, 2020

bors-servo commented Jan 17, 2020

bors-servo commented Jan 17, 2020

bors-servo commented Jan 17, 2020

SimonSapin commented Jan 17, 2020

bors-servo commented Jan 17, 2020

bors-servo commented Jan 17, 2020

SimonSapin commented Jan 17, 2020

bors-servo commented Jan 17, 2020

bors-servo commented Jan 17, 2020