Modify `script` to prevent further violations of snake_case #25547

kunalmohan · 2020-01-17T20:07:12Z

Remove #![allow(non_snake_case)] from script/lib.rs and add #[allow(non_snake_case)] at each instance of violation.

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix #25531 (GitHub issue number if applicable)

highfive · 2020-01-17T20:07:20Z

Heads up! This PR modifies the following files:

@asajeffrey: components/script/dom/request.rs, components/script/test.rs, components/script/dom/textencoder.rs, components/script/dom/rtcpeerconnectioniceevent.rs, components/script/dom/dompoint.rs and 126 more
@KiChjang: components/script/dom/request.rs, components/script/test.rs, components/script/dom/textencoder.rs, components/script/dom/rtcpeerconnectioniceevent.rs, components/script/dom/dompoint.rs and 126 more

jdm · 2020-01-17T20:33:48Z

error: variable `storeBindings` should have a snake case name
   --> components/script/dom/gpudevice.rs:253:17
    |
253 |         let mut storeBindings = HashSet::new();
    |                 ^^^^^^^^^^^^^ help: convert the identifier to snake case: `store_bindings`
    |
    = note: `-D non-snake-case` implied by `-D warnings`
error: variable `maxLimits` should have a snake case name
   --> components/script/dom/gpudevice.rs:258:13
    |
258 |         let maxLimits = MaxLimits {
    |             ^^^^^^^^^ help: convert the identifier to snake case: `max_limits`
error: aborting due to 2 previous errors

A couple more that you'll need to rebase to address. Otherwise I think this is a good choice :)

pshaughn · 2020-01-18T00:10:00Z

components/script/webdriver_handlers.rs

@@ -366,6 +366,7 @@ pub fn handle_get_browsing_context_id(
 }

 // https://w3c.github.io/webdriver/#dfn-center-point
+#[allow(non_snake_case)]


This one can be fully snake-cased; the violations are just variable names.

pshaughn · 2020-01-18T00:11:11Z

components/script/script_runtime.rs

@@ -900,7 +900,7 @@ impl StreamConsumer {

 /// Implements the steps to compile webassembly response mentioned here
 /// <https://webassembly.github.io/spec/web-api/#compile-a-potential-webassembly-response>
-#[allow(unsafe_code)]
+#[allow(unsafe_code, non_snake_case)]


I think this one can be fully snake cased; the only violation I see is the parameter name _mimeType.

pshaughn · 2020-01-18T00:12:42Z

components/script/fetch.rs

@@ -349,6 +349,7 @@ pub fn load_whole_resource(
 }

 /// https://html.spec.whatwg.org/multipage/#create-a-potential-cors-request
+#[allow(non_snake_case)]
 pub(crate) fn create_a_potential_CORS_request(


I think we usually leave "cors" lowercase, and can snake_case this

pshaughn · 2020-01-18T00:13:51Z

components/script/dom/headers.rs

@@ -393,6 +394,7 @@ pub fn normalize_value(value: ByteString) -> ByteString {
    }
 }

+#[allow(non_snake_case)]
 fn is_HTTP_whitespace(byte: u8) -> bool {


http could be lowercase here

pshaughn · 2020-01-18T00:15:30Z

components/script/dom/bluetoothremotegattcharacteristic.rs

@@ -62,6 +62,7 @@ impl BluetoothRemoteGATTCharacteristic {
        }
    }

+    #[allow(non_snake_case)]
    pub fn new(


This can be snake-case, it's just the parameter instanceID

pshaughn · 2020-01-18T00:16:03Z

components/script/dom/bluetoothremotegattdescriptor.rs

@@ -51,6 +51,7 @@ impl BluetoothRemoteGATTDescriptor {
        }
    }

+    #[allow(non_snake_case)]
    pub fn new(


like the above comment, just the instanceID parameter

pshaughn · 2020-01-18T00:16:48Z

components/script/dom/dommatrixreadonly.rs

@@ -738,6 +741,7 @@ pub fn entries_to_matrix(entries: &[f64]) -> Fallible<(bool, Transform3D<f64>)>
 }

 // https://drafts.fxtf.org/geometry-1/#validate-and-fixup
+#[allow(non_snake_case)]
 pub fn dommatrixinit_to_matrix(dict: &DOMMatrixInit) -> Fallible<(bool, Transform3D<f64>)> {


I think this one's just the is2D local variable.

pshaughn · 2020-01-18T02:23:46Z

Oh, I think I misunderstood the purpose of this commit! Those comments are still worth having somewhere to look at later, but they're not necessarily for this pr in particular.

kunalmohan · 2020-01-18T07:44:40Z

I think I'll do it here itself. It shouldn't take much time at this stage.


        Modify `script` to prevent further violations of snake_case

jdm · 2020-01-19T22:13:44Z

@bors-servo r+

bors-servo · 2020-01-19T22:13:45Z

📌 Commit f7db4b7 has been approved by jdm

bors-servo · 2020-01-19T22:54:33Z

⌛ Testing commit f7db4b7 with merge e2bc874...


        Auto merge of #25547 - kunalmohan:25531-SnakeCase, r=jdm

Modify `script` to prevent further violations of snake_case  Remove `#![allow(non_snake_case)]` from `script/lib.rs` and add `#[allow(non_snake_case)]` at each instance of violation. ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #25531 (GitHub issue number if applicable)

bors-servo · 2020-01-19T23:51:17Z

💔 Test failed - status-taskcluster

jdm · 2020-01-20T01:01:48Z

@bors-servo retry

bors-servo · 2020-01-20T01:40:23Z

💔 Test failed - status-taskcluster

jdm · 2020-01-20T07:07:59Z

@bors-servo retry


        Auto merge of #25547 - kunalmohan:25531-SnakeCase, r=jdm

Modify `script` to prevent further violations of snake_case  Remove `#![allow(non_snake_case)]` from `script/lib.rs` and add `#[allow(non_snake_case)]` at each instance of violation. ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #25531 (GitHub issue number if applicable)

bors-servo · 2020-01-20T07:08:08Z

⌛ Testing commit f7db4b7 with merge 28078bd...

bors-servo · 2020-01-20T07:51:18Z

💔 Test failed - status-taskcluster

CYBAI · 2020-01-20T08:07:45Z

@bors-servo retry

#25522

bors-servo · 2020-01-20T08:07:51Z

⌛ Testing commit f7db4b7 with merge 6b0e0a5...


        Auto merge of #25547 - kunalmohan:25531-SnakeCase, r=jdm

Modify `script` to prevent further violations of snake_case  Remove `#![allow(non_snake_case)]` from `script/lib.rs` and add `#[allow(non_snake_case)]` at each instance of violation. ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #25531 (GitHub issue number if applicable)

bors-servo · 2020-01-20T08:34:45Z

💔 Test failed - status-taskcluster

CYBAI · 2020-01-20T09:05:24Z

@bors-servo retry

#25513

bors-servo · 2020-01-20T09:05:29Z

⌛ Testing commit f7db4b7 with merge 74d1f02...


        Auto merge of #25547 - kunalmohan:25531-SnakeCase, r=jdm

Modify `script` to prevent further violations of snake_case  Remove `#![allow(non_snake_case)]` from `script/lib.rs` and add `#[allow(non_snake_case)]` at each instance of violation. ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #25531 (GitHub issue number if applicable)

bors-servo · 2020-01-20T09:06:29Z

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 74d1f02 to master...

highfive assigned SimonSapin Jan 17, 2020

highfive added the S-awaiting-review label Jan 17, 2020

jdm added S-needs-code-changes and removed S-awaiting-review labels Jan 17, 2020

highfive added S-awaiting-review and removed S-needs-code-changes labels Jan 17, 2020

pshaughn reviewed Jan 18, 2020

View changes

Modify `script` to prevent further violations of snake_case

Verified

This commit was signed with a verified signature.

kunalmohan Kunal Mohan

GPG key ID: 2B475A4524237BAC Learn about signing commits

Loading status checks…

f7db4b7

highfive assigned jdm and unassigned SimonSapin Jan 19, 2020

highfive added S-awaiting-merge and removed S-awaiting-review labels Jan 19, 2020

highfive added S-tests-failed and removed S-awaiting-merge labels Jan 19, 2020

highfive added S-tests-failed and removed S-awaiting-merge labels Jan 20, 2020

highfive added S-awaiting-merge and removed S-tests-failed labels Jan 20, 2020

highfive added S-tests-failed and removed S-awaiting-merge labels Jan 20, 2020

highfive added S-awaiting-merge and removed S-tests-failed labels Jan 20, 2020

highfive added S-tests-failed and removed S-awaiting-merge labels Jan 20, 2020

highfive added S-awaiting-merge and removed S-tests-failed labels Jan 20, 2020

bors-servo merged commit f7db4b7 into servo:master Jan 20, 2020
2 checks passed

2 checks passed

Community-TC (pull_request) TaskGroup: success
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Jan 20, 2020

kunalmohan deleted the kunalmohan:25531-SnakeCase branch Jan 20, 2020

This was referenced Jan 20, 2020

Refactor ImageCache::find_image_or_metadata -> ImageCache::{get_image, track_image} #23661

Merged

[WIP] Mutation observer test fix #21456

Open

servo / servo

Modify `script` to prevent further violations of snake_case #25547

Modify `script` to prevent further violations of snake_case #25547

kunalmohan commented Jan 17, 2020

highfive commented Jan 17, 2020

jdm commented Jan 17, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

pshaughn commented Jan 18, 2020

kunalmohan commented Jan 18, 2020

jdm commented Jan 19, 2020

bors-servo commented Jan 19, 2020

bors-servo commented Jan 19, 2020

bors-servo commented Jan 19, 2020

jdm commented Jan 20, 2020

bors-servo commented Jan 20, 2020

jdm commented Jan 20, 2020

bors-servo commented Jan 20, 2020

bors-servo commented Jan 20, 2020

CYBAI commented Jan 20, 2020

bors-servo commented Jan 20, 2020

bors-servo commented Jan 20, 2020

CYBAI commented Jan 20, 2020

bors-servo commented Jan 20, 2020

bors-servo commented Jan 20, 2020

servo / servo

Join GitHub today

Modify `script` to prevent further violations of snake_case #25547

Modify `script` to prevent further violations of snake_case #25547

Conversation

kunalmohan commented Jan 17, 2020

highfive commented Jan 17, 2020

jdm commented Jan 17, 2020

This comment has been minimized.

pshaughn Jan 18, 2020

This comment has been minimized.

pshaughn Jan 18, 2020

This comment has been minimized.

pshaughn Jan 18, 2020

This comment has been minimized.

pshaughn Jan 18, 2020

This comment has been minimized.

pshaughn Jan 18, 2020

This comment has been minimized.

pshaughn Jan 18, 2020

This comment has been minimized.

pshaughn Jan 18, 2020

pshaughn commented Jan 18, 2020

kunalmohan commented Jan 18, 2020

jdm commented Jan 19, 2020

bors-servo commented Jan 19, 2020

bors-servo commented Jan 19, 2020

bors-servo commented Jan 19, 2020

jdm commented Jan 20, 2020

bors-servo commented Jan 20, 2020

jdm commented Jan 20, 2020

bors-servo commented Jan 20, 2020

bors-servo commented Jan 20, 2020

CYBAI commented Jan 20, 2020

bors-servo commented Jan 20, 2020

bors-servo commented Jan 20, 2020

CYBAI commented Jan 20, 2020

bors-servo commented Jan 20, 2020

bors-servo commented Jan 20, 2020