Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix canvas wpt test `path-objects/2d.path.rect.zero.4.html` #25551
Conversation
Step 4 has been missing. https://html.spec.whatwg.org/multipage/canvas.html#dom-context-2d-rect
|
r? @jdm |
|
@bors-servo try=wpt |
bors-servo
added a commit
that referenced
this pull request
Jan 19, 2020
Fix canvas wpt test `path-objects/2d.path.rect.zero.4.html` <!-- Please describe your changes on the following line: --> After connecting the lines of a rectangle, a new subpath has to be created containing the rectangle's origin as the only point in the subpath. (see step 4 of https://html.spec.whatwg.org/multipage/canvas.html#dom-context-2d-rect) --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix part of #25331 <!-- Either: --> - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
Good find! |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 19, 2020
Fix canvas wpt test `path-objects/2d.path.rect.zero.4.html` <!-- Please describe your changes on the following line: --> After connecting the lines of a rectangle, a new subpath has to be created containing the rectangle's origin as the only point in the subpath. (see step 4 of https://html.spec.whatwg.org/multipage/canvas.html#dom-context-2d-rect) --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix part of #25331 <!-- Either: --> - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Jan 19, 2020
Fix canvas wpt test `path-objects/2d.path.rect.zero.4.html` <!-- Please describe your changes on the following line: --> After connecting the lines of a rectangle, a new subpath has to be created containing the rectangle's origin as the only point in the subpath. (see step 4 of https://html.spec.whatwg.org/multipage/canvas.html#dom-context-2d-rect) --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix part of #25331 <!-- Either: --> - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pylbrecht commentedJan 19, 2020
After connecting the lines of a rectangle, a new subpath has to be created containing the rectangle's origin as the only point in the subpath.
(see step 4 of https://html.spec.whatwg.org/multipage/canvas.html#dom-context-2d-rect)
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors