Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upReturn the highest priority error from the descendant instead of return the very first one #25552
Conversation
highfive
commented
Jan 19, 2020
|
Heads up! This PR modifies the following files:
|
|
r? @Manishearth |
|
@bors-servo try=wpt |
bors-servo
added a commit
that referenced
this pull request
Jan 19, 2020
Return the highest priority error from the descendant instead of return the very first one The test failed because we didn't return the highest priority error (which is network error in this case). As Manish mentioned in #25436 (comment), that's because we're using the Promise.all trick to signal loads. If we can avoid relying on Promise.all, maybe we don't need to do a complex logic like this; instead, ideally, we should always finish the module load immediately when we hit network failure so that we don't even need to do the `max()` comparison. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #25436 - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
The failure is #25522 |
|
Looks sensible! |
…rn the very first one
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 20, 2020
Return the highest priority error from the descendant instead of return the very first one The test failed because we didn't return the highest priority error (which is network error in this case). As Manish mentioned in #25436 (comment), that's because we're using the Promise.all trick to signal loads. If we can avoid relying on Promise.all, maybe we don't need to do a complex logic like this; instead, ideally, we should always finish the module load immediately when we hit network failure so that we don't even need to do the `max()` comparison. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #25436 - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Jan 20, 2020
Return the highest priority error from the descendant instead of return the very first one The test failed because we didn't return the highest priority error (which is network error in this case). As Manish mentioned in #25436 (comment), that's because we're using the Promise.all trick to signal loads. If we can avoid relying on Promise.all, maybe we don't need to do a complex logic like this; instead, ideally, we should always finish the module load immediately when we hit network failure so that we don't even need to do the `max()` comparison. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #25436 - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
CYBAI commentedJan 19, 2020
The test failed because we didn't return the highest priority error (which is network error in this case).
As Manish mentioned in #25436 (comment), that's because we're using the Promise.all trick to signal loads.
If we can avoid relying on Promise.all, maybe we don't need to do a complex logic like this; instead, ideally, we should always finish the module load immediately when we hit network failure so that we don't even need to do the
max()comparison../mach build -ddoes not report any errors./mach test-tidydoes not report any errors