Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PR that introduced frequent linux reftest failures #25566

Closed
wants to merge 1 commit into from
Closed

Revert PR that introduced frequent linux reftest failures #25566

wants to merge 1 commit into from

Conversation

@jdm
Copy link
Member

jdm commented Jan 21, 2020 •
edited

This should reduce the frequency of #24726.
@highfive
Copy link

highfive commented Jan 21, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/window.rs, components/constellation/pipeline.rs, components/script/script_thread.rs, components/script/dom/htmliframeelement.rs, components/constellation/constellation.rs and 1 more
  • @cbrewster: components/constellation/pipeline.rs, components/constellation/constellation.rs, components/constellation/session_history.rs
  • @KiChjang: components/script/dom/window.rs, components/script_traits/lib.rs, components/script/script_thread.rs, components/script/dom/htmliframeelement.rs
  • @emilio: components/layout/display_list/builder.rs, components/layout/query.rs
@jdm
Copy link
Member Author

jdm commented Jan 21, 2020

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Jan 21, 2020

⌛ Trying commit 2d88e47 with merge 4a6750f...
bors-servo added a commit that referenced this pull request Jan 21, 2020
@bors-servo
Auto merge of #25566 - jdm:revert-iframes, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4a6750f 
Revert #24677 due to frequent intermittent reftest failures.

This should fix #24726.
@jdm jdm changed the title Revert #24677 due to frequent intermittent reftest failures. Revert PR that introduced frequent linux reftest failures Jan 21, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Jan 21, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented Jan 21, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jan 21, 2020

⌛ Trying commit 2d88e47 with merge b761e48...
bors-servo added a commit that referenced this pull request Jan 21, 2020
@bors-servo
Auto merge of #25566 - jdm:revert-iframes, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b761e48 
Revert PR that introduced frequent linux reftest failures

This should fix #24726.
This was referenced Jan 21, 2020
Closed
Closed
@bors-servo
Copy link
Contributor

bors-servo commented Jan 21, 2020

☀️ Test successful - status-taskcluster
State: approved= try=True
@asajeffrey
Copy link
Member

asajeffrey commented Jan 21, 2020

Pity, I liked #24677. You can r=me.
@jdm
Copy link
Member Author

jdm commented Jan 21, 2020

@bors-servo r=asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented Jan 21, 2020

📌 Commit 2d88e47 has been approved by asajeffrey
@highfive highfive assigned asajeffrey and unassigned Manishearth Jan 21, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Jan 21, 2020

⌛ Testing commit 2d88e47 with merge 58da464...
bors-servo added a commit that referenced this pull request Jan 21, 2020
@bors-servo
Auto merge of #25566 - jdm:revert-iframes, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
58da464 
Revert PR that introduced frequent linux reftest failures

This should fix #24726.
@jdm
Copy link
Member Author

jdm commented Jan 21, 2020

I plan to reintroduce the changes from #24677, but now that I know there's a bug somewhere it will be easier to identify its source starting from a known-working revision, rather than trying to undo historical changes in a broken revision.
@bors-servo
Copy link
Contributor

bors-servo commented Jan 21, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented Jan 21, 2020 

1 unexpected results that are NOT known-intermittents:
  ▶ FAIL [expected PASS] /css/CSS2/bidi-text/bidi-box-model-001.xht
  │   → /css/CSS2/bidi-text/bidi-box-model-001.xht 54a9df64f1476dd12020019d7cf22ac34d727bc0
  │   → /css/CSS2/bidi-text/bidi-box-model-001-ref.xht e597a04d78f1523f67bd3e2a01e4b8ad831bd031
  └   → Screenshot is solid color 0xFFFFFF for /css/CSS2/bidi-text/bidi-box-model-001.xht

ARRRRRRRRRRRRRGH
@bors-servo
Copy link
Contributor

bors-servo commented Feb 15, 2020

⌛ Testing commit 31074a4 with merge a46ddd2...
bors-servo added a commit that referenced this pull request Feb 15, 2020
@bors-servo
Auto merge of #25566 - jdm:revert-iframes, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a46ddd2 
Revert PR that introduced frequent linux reftest failures

This should reduce the frequency of #24726.
@bors-servo
Copy link
Contributor

bors-servo commented Feb 15, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented Feb 15, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 15, 2020

⌛ Testing commit 31074a4 with merge 0a3d918...
bors-servo added a commit that referenced this pull request Feb 15, 2020
@bors-servo
Auto merge of #25566 - jdm:revert-iframes, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0a3d918 
Revert PR that introduced frequent linux reftest failures

This should reduce the frequency of #24726.
@bors-servo
Copy link
Contributor

bors-servo commented Feb 15, 2020

💔 Test failed - status-taskcluster
@jdm
Revert #24677 due to frequent intermittent reftest failures.
Loading status checks…
cecdec9
@jdm jdm force-pushed the jdm:revert-iframes branch from 31074a4 to cecdec9 Feb 15, 2020
@jdm
Copy link
Member Author

jdm commented Feb 15, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Feb 15, 2020

📌 Commit cecdec9 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Feb 15, 2020

⌛ Testing commit cecdec9 with merge e6cc0fc...
bors-servo added a commit that referenced this pull request Feb 15, 2020
@bors-servo
Auto merge of #25566 - jdm:revert-iframes, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e6cc0fc 
Revert PR that introduced frequent linux reftest failures

This should reduce the frequency of #24726.
@bors-servo
Copy link
Contributor

bors-servo commented Feb 15, 2020

💔 Test failed - status-taskcluster
@bors-servo
Copy link
Contributor

bors-servo commented Feb 19, 2020

☔ The latest upstream changes (presumably #25777) made this pull request unmergeable. Please resolve the merge conflicts.
@jdm
Copy link
Member Author

jdm commented Feb 24, 2020

No longer needed.
@jdm jdm closed this Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-needs-rebase S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@jdm @highfive @bors-servo @asajeffrey @Manishearth
You can’t perform that action at this time.