Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let custom element registry know about picture tag #25578

Merged
merged 1 commit into from Jan 24, 2020
Merged

Let custom element registry know about picture tag #25578

merged 1 commit into from Jan 24, 2020

Conversation

@pshaughn
Copy link
Member

pshaughn commented Jan 23, 2020

This replaces one WPT failure with another, but the previous one failure was preventing multiple cases from running, and now only one of those cases fails (due to #24993).

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #25577
  • There are tests for these changes
@highfive
Copy link

highfive commented Jan 23, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/customelementregistry.rs
  • @KiChjang: components/script/dom/customelementregistry.rs
@jdm
Copy link
Member

jdm commented Jan 23, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 23, 2020

📌 Commit 59f05ae has been approved by jdm
@highfive highfive assigned jdm and unassigned asajeffrey Jan 23, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Jan 23, 2020

⌛ Testing commit 59f05ae with merge 74616bd...
bors-servo added a commit that referenced this pull request Jan 23, 2020
@bors-servo
Auto merge of #25578 - pshaughn:custompicture, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
74616bd 
Let custom element registry know about picture tag

<!-- Please describe your changes on the following line: -->
This replaces one WPT failure with another, but the previous one failure was preventing multiple cases from running, and now only one of those cases fails (due to #24993).

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25577

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 23, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Jan 23, 2020 

1 unexpected results that are NOT known-intermittents:
  â–¶ ERROR [expected OK] /custom-elements/builtin-coverage.html
  │   → Custom element does not extend the proper interface
  │ 
  │ @http://web-platform.test:8000/custom-elements/builtin-coverage.html line 138 > eval:1:49
  │ @http://web-platform.test:8000/custom-elements/builtin-coverage.html:170:61
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2024:25
  │ test@http://web-platform.test:8000/resources/testharness.js:548:30
  │ @http://web-platform.test:8000/custom-elements/builtin-coverage.html:165:5
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2024:25
  │ test@http://web-platform.test:8000/resources/testharness.js:548:30
  â”” @http://web-platform.test:8000/custom-elements/builtin-coverage.html:136:3

  â–¶ Unexpected subtest result in /custom-elements/builtin-coverage.html:
  │ FAIL [expected PASS] picture: innerHTML should instantiate a customized built-in element
  │   → assert_equals: expected function "class extends HTMLPictureElement {}" but got function "function HTMLPictureElement() {
  │   →     [native code]
  │   → }"
  │ 
  │ @http://web-platform.test:8000/custom-elements/builtin-coverage.html:173:7
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2024:25
  │ test@http://web-platform.test:8000/resources/testharness.js:548:30
  │ @http://web-platform.test:8000/custom-elements/builtin-coverage.html:165:5
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2024:25
  │ test@http://web-platform.test:8000/resources/testharness.js:548:30
  â”” @http://web-platform.test:8000/custom-elements/builtin-coverage.html:136:3

  â–¶ Unexpected subtest result in /custom-elements/builtin-coverage.html:
  │ FAIL [expected PASS] picture: document.createElement() should instantiate a customized built-in element
  │   → assert_equals: expected function "class extends HTMLPictureElement {}" but got function "function HTMLPictureElement() {
  │   →     [native code]
  │   → }"
  │ 
  │ @http://web-platform.test:8000/custom-elements/builtin-coverage.html:150:7
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2024:25
  │ test@http://web-platform.test:8000/resources/testharness.js:548:30
  │ @http://web-platform.test:8000/custom-elements/builtin-coverage.html:148:5
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2024:25
  │ test@http://web-platform.test:8000/resources/testharness.js:548:30
  â”” @http://web-platform.test:8000/custom-elements/builtin-coverage.html:136:3
@pshaughn
Let custom element registry know about picture tag
Loading status checks…
eb24637
@pshaughn pshaughn force-pushed the pshaughn:custompicture branch from 59f05ae to eb24637 Jan 23, 2020
@pshaughn
Copy link
Member Author

pshaughn commented Jan 23, 2020

First push missed a similar change in htmlconstructor.rs, this one works.
@jdm
Copy link
Member

jdm commented Jan 23, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 23, 2020

📌 Commit eb24637 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jan 23, 2020

⌛ Testing commit eb24637 with merge e2302d3...
bors-servo added a commit that referenced this pull request Jan 23, 2020
@bors-servo
Auto merge of #25578 - pshaughn:custompicture, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e2302d3 
Let custom element registry know about picture tag

<!-- Please describe your changes on the following line: -->
This replaces one WPT failure with another, but the previous one failure was preventing multiple cases from running, and now only one of those cases fails (due to #24993).

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25577

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 23, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Jan 23, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jan 23, 2020

⌛ Testing commit eb24637 with merge e3bd7c2...
bors-servo added a commit that referenced this pull request Jan 23, 2020
@bors-servo
Auto merge of #25578 - pshaughn:custompicture, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e3bd7c2 
Let custom element registry know about picture tag

<!-- Please describe your changes on the following line: -->
This replaces one WPT failure with another, but the previous one failure was preventing multiple cases from running, and now only one of those cases fails (due to #24993).

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25577

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 23, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Jan 24, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jan 24, 2020

⌛ Testing commit eb24637 with merge 31dfb56...
bors-servo added a commit that referenced this pull request Jan 24, 2020
@bors-servo
Auto merge of #25578 - pshaughn:custompicture, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
31dfb56 
Let custom element registry know about picture tag

<!-- Please describe your changes on the following line: -->
This replaces one WPT failure with another, but the previous one failure was preventing multiple cases from running, and now only one of those cases fails (due to #24993).

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25577

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 24, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Jan 24, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jan 24, 2020

⌛ Testing commit eb24637 with merge 8b9018c...
bors-servo added a commit that referenced this pull request Jan 24, 2020
@bors-servo
Auto merge of #25578 - pshaughn:custompicture, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8b9018c 
Let custom element registry know about picture tag

<!-- Please describe your changes on the following line: -->
This replaces one WPT failure with another, but the previous one failure was preventing multiple cases from running, and now only one of those cases fails (due to #24993).

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25577

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 24, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 8b9018c to master...
@bors-servo bors-servo merged commit eb24637 into servo:master Jan 24, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Can't create a custom element based on HTMLPictureElement
5 participants
@pshaughn @highfive @jdm @bors-servo @asajeffrey
You can’t perform that action at this time.