Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support worker for WebGPU #25580

Merged
merged 1 commit into from Jan 23, 2020
Merged

Support worker for WebGPU #25580

merged 1 commit into from Jan 23, 2020
+97 −122

Conversation

@imiklos
Copy link
Contributor

imiklos commented Jan 23, 2020

To create resource ids for the WebGPU we need to access the IdentityHub.
In order to access the IdentityHub from a Window or a Worker as well, I've moved the IdentityHub to the GlobalScope from the Navigator.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #25532

cc @kvark @jdm @zakorgy
@imiklos
Support worker for WebGPU
Loading status checks…
dbed5f1 
To create resource ids for the WebGPU we need to access the `IdentityHub`.
In order to access the `IdentityHub` from a `Window` or a `Worker` as well, I've moved the `IdentityHub` to the `GlobalScope` from the `Navigator`.
@highfive
Copy link

highfive commented Jan 23, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/globalscope.rs, components/script/dom/gpuadapter.rs, components/script/dom/gpudevice.rs, components/script/dom/navigator.rs, components/script/dom/gpu.rs
  • @KiChjang: components/script/dom/globalscope.rs, components/script/dom/gpuadapter.rs, components/script/dom/gpudevice.rs, components/script/dom/navigator.rs, components/script/dom/gpu.rs
@highfive
Copy link

highfive commented Jan 23, 2020

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented Jan 23, 2020

@bors-servo r+
Thanks!
@bors-servo
Copy link
Contributor

bors-servo commented Jan 23, 2020

📌 Commit dbed5f1 has been approved by jdm
@highfive highfive assigned jdm and unassigned Manishearth Jan 23, 2020
bors-servo added a commit that referenced this pull request Jan 23, 2020
@bors-servo
Auto merge of #25580 - szeged:wgpu_worker, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
384bdac 
Support worker for WebGPU

To create resource ids for the WebGPU we need to access the `IdentityHub`.
In order to access the `IdentityHub` from a `Window` or a `Worker` as well, I've moved the `IdentityHub` to the `GlobalScope` from the `Navigator`.

<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25532

cc @kvark @jdm @zakorgy
@bors-servo
Copy link
Contributor

bors-servo commented Jan 23, 2020

⌛ Testing commit dbed5f1 with merge 384bdac...
@bors-servo
Copy link
Contributor

bors-servo commented Jan 23, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Jan 23, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jan 23, 2020

⌛ Testing commit dbed5f1 with merge d015335...
bors-servo added a commit that referenced this pull request Jan 23, 2020
@bors-servo
Auto merge of #25580 - szeged:wgpu_worker, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d015335 
Support worker for WebGPU

To create resource ids for the WebGPU we need to access the `IdentityHub`.
In order to access the `IdentityHub` from a `Window` or a `Worker` as well, I've moved the `IdentityHub` to the `GlobalScope` from the `Navigator`.

<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25532

cc @kvark @jdm @zakorgy
@bors-servo
Copy link
Contributor

bors-servo commented Jan 23, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Jan 23, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jan 23, 2020

⌛ Testing commit dbed5f1 with merge 2b77a99...
bors-servo added a commit that referenced this pull request Jan 23, 2020
@bors-servo
Auto merge of #25580 - szeged:wgpu_worker, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2b77a99 
Support worker for WebGPU

To create resource ids for the WebGPU we need to access the `IdentityHub`.
In order to access the `IdentityHub` from a `Window` or a `Worker` as well, I've moved the `IdentityHub` to the `GlobalScope` from the `Navigator`.

<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25532

cc @kvark @jdm @zakorgy
@bors-servo
Copy link
Contributor

bors-servo commented Jan 23, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 2b77a99 to master...
@bors-servo bors-servo merged commit dbed5f1 into servo:master Jan 23, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Support worker globals for webgpu
5 participants
@imiklos @highfive @jdm @bors-servo @Manishearth
You can’t perform that action at this time.