Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update windows llvm to 8.0.1. #25586

Merged
merged 1 commit into from Jan 24, 2020
Merged

Update windows llvm to 8.0.1. #25586

merged 1 commit into from Jan 24, 2020
+1 −1

Conversation

@jdm
Copy link
Member

jdm commented Jan 23, 2020

This makes it possible to build mozjs with llvm's clang-cl and MSVC 2019's header files; otherwise the headers check the clang version and abort compilation because it's 8.0 is too old.
@jdm
Update windows llvm to 8.0.1.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f4c1837
@highfive
Copy link

highfive commented Jan 23, 2020

Heads up! This PR modifies the following files:
@Manishearth
Copy link
Member

Manishearth commented Jan 23, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 23, 2020

📌 Commit f4c1837 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Jan 23, 2020

⌛ Testing commit f4c1837 with merge c664e64...
bors-servo added a commit that referenced this pull request Jan 23, 2020
@bors-servo
Auto merge of #25586 - servo:jdm-patch-35, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c664e64 
Update windows llvm to 8.0.1.

This makes it possible to build mozjs with llvm's clang-cl and MSVC 2019's header files; otherwise the headers check the clang version and abort compilation because it's 8.0 is too old.
@bors-servo
Copy link
Contributor

bors-servo commented Jan 23, 2020

💔 Test failed - status-taskcluster
@Manishearth
Copy link
Member

Manishearth commented Jan 23, 2020

@bors-servo r+

1 unexpected results that are NOT known-intermittents:
  ▶ FAIL [expected PASS] /css/selectors/old-tests/css3-modsel-157.xml
  │   → /css/selectors/old-tests/css3-modsel-157.xml 54a9df64f1476dd12020019d7cf22ac34d727bc0
  │   → /css/selectors/old-tests/reference/this-line-lime-background.xht c49f5fda9b3b8813d24ff192a7c68060414f324a
  └   → Screenshot is solid color 0xFFFFFF for /css/selectors/old-tests/css3-modsel-157.xml

seeing these again :/
@bors-servo
Copy link
Contributor

bors-servo commented Jan 23, 2020

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
  • There's another pull request that is currently being tested, blocking this pull request: #25490
@bors-servo
Copy link
Contributor

bors-servo commented Jan 23, 2020

📌 Commit f4c1837 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Jan 23, 2020

⌛ Testing commit f4c1837 with merge 0bd5068...
bors-servo added a commit that referenced this pull request Jan 23, 2020
@bors-servo
Auto merge of #25586 - servo:jdm-patch-35, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0bd5068 
Update windows llvm to 8.0.1.

This makes it possible to build mozjs with llvm's clang-cl and MSVC 2019's header files; otherwise the headers check the clang version and abort compilation because it's 8.0 is too old.
@bors-servo
Copy link
Contributor

bors-servo commented Jan 23, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented Jan 24, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jan 24, 2020

⌛ Testing commit f4c1837 with merge 425328a...
bors-servo added a commit that referenced this pull request Jan 24, 2020
@bors-servo
Auto merge of #25586 - servo:jdm-patch-35, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
425328a 
Update windows llvm to 8.0.1.

This makes it possible to build mozjs with llvm's clang-cl and MSVC 2019's header files; otherwise the headers check the clang version and abort compilation because it's 8.0 is too old.
@bors-servo
Copy link
Contributor

bors-servo commented Jan 24, 2020

☀️ Test successful - status-taskcluster
Approved by: Manishearth
Pushing 425328a to master...
@bors-servo bors-servo merged commit f4c1837 into master Jan 24, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@bors-servo bors-servo deleted the jdm-patch-35 branch Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@jdm @highfive @Manishearth @bors-servo
You can’t perform that action at this time.