Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename compartment to realm #25597

Merged
merged 1 commit into from Jan 24, 2020
Merged

Rename compartment to realm #25597

merged 1 commit into from Jan 24, 2020

Conversation

@kunalmohan
Copy link
Collaborator

kunalmohan commented Jan 24, 2020

Rename compartment-related terminology to use realms instead.

r?@jdm

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #25581 (GitHub issue number if applicable)
@kunalmohan
rename compartment to realm
Verified
This commit was signed with a verified signature.
kunalmohan Kunal Mohan
GPG key ID: 2B475A4524237BAC Learn about signing commits
Loading status checks…
5a3e1b8
@highfive
Copy link

highfive commented Jan 24, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/navigator.rs, components/script/dom/rtcpeerconnection.rs, components/script/dom/vrdisplay.rs, components/script/dom/customelementregistry.rs, components/script/dom/filereader.rs and 48 more
  • @KiChjang: components/script/dom/navigator.rs, components/script/dom/rtcpeerconnection.rs, components/script/dom/vrdisplay.rs, components/script/dom/customelementregistry.rs, components/script/dom/filereader.rs and 48 more
@jdm
Copy link
Member

jdm commented Jan 24, 2020

@bors-servo r+
Looks good! Thanks for cleaning this up!
@bors-servo
Copy link
Contributor

bors-servo commented Jan 24, 2020

📌 Commit 5a3e1b8 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jan 24, 2020

⌛ Testing commit 5a3e1b8 with merge 12693b5...
bors-servo added a commit that referenced this pull request Jan 24, 2020
@bors-servo
Auto merge of #25597 - kunalmohan:25581-Compartment, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
12693b5 
Rename compartment to realm

<!-- Please describe your changes on the following line: -->
Rename compartment-related terminology to use realms instead.

r?@jdm

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25581 (GitHub issue number if applicable)

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 24, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 12693b5 to master...
@bors-servo bors-servo merged commit 5a3e1b8 into servo:master Jan 24, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
This was referenced Jan 24, 2020
Merged
Merged
Merged
@kunalmohan kunalmohan deleted the kunalmohan:25581-Compartment branch Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Rename compartment-related terminology to use realms instead
4 participants
@kunalmohan @highfive @jdm @bors-servo
You can’t perform that action at this time.