Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement :defined CSS selector #25627

Merged
merged 1 commit into from Jan 31, 2020
Merged

Implement :defined CSS selector #25627

merged 1 commit into from Jan 31, 2020

Conversation

@pshaughn
Copy link
Member

pshaughn commented Jan 28, 2020

ElementState::IN_DEFINED_STATE already existed but wasn't hooked up to anything; now it is set appropriately, and CSS is aware of it. The main test for this selector needed the window named getter for no important reason, so I made a one-line test change to avoid that. Remaining failures in the test are all about SVG elements.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #25010
  • There are tests for these changes OR
  • These changes do not require tests because ___
@highfive
Copy link

highfive commented Jan 28, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/create.rs, components/script/dom/element.rs
  • @KiChjang: components/script/dom/create.rs, components/script/dom/element.rs
  • @emilio: components/style/servo/selector_parser.rs
@servo-wpt-sync servo-wpt-sync mentioned this pull request Jan 28, 2020
Merged
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Jan 28, 2020

Opened new PR for upstreamable changes.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#21455.
@emilio
emilio reviewed Jan 28, 2020
View changes
components/style/servo/selector_parser.rs Outdated Show resolved Hide resolved
tests/wpt/web-platform-tests/custom-elements/pseudo-class-defined.html Outdated Show resolved Hide resolved
@pshaughn pshaughn force-pushed the pshaughn:definedpseudo branch from 8b7027b to c234a6c Jan 28, 2020
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Jan 28, 2020

Transplanted upstreamable changes to existing PR.

Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#21455.
@jdm
Copy link
Member

jdm commented Jan 28, 2020

@bors-servo r=emilio,jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jan 28, 2020

📌 Commit c234a6c has been approved by emilio,jdm
@highfive highfive assigned emilio and unassigned jdm Jan 28, 2020
bors-servo added a commit that referenced this pull request Jan 28, 2020
@bors-servo
Auto merge of #25627 - pshaughn:definedpseudo, r=emilio,jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7416c22 
Implement :defined CSS selector

<!-- Please describe your changes on the following line: -->
ElementState::IN_DEFINED_STATE already existed but wasn't hooked up to anything; now it is set appropriately, and CSS is aware of it. The main test for this selector needed the window named getter for no important reason, so I made a one-line test change to avoid that. Remaining failures in the test are all about SVG elements.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25010

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 28, 2020

⌛ Testing commit c234a6c with merge 7416c22...
@bors-servo
Copy link
Contributor

bors-servo commented Jan 28, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Jan 28, 2020

@bors-servo retry
bors-servo added a commit that referenced this pull request Jan 28, 2020
@bors-servo
Auto merge of #25627 - pshaughn:definedpseudo, r=emilio,jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0e25eec 
Implement :defined CSS selector

<!-- Please describe your changes on the following line: -->
ElementState::IN_DEFINED_STATE already existed but wasn't hooked up to anything; now it is set appropriately, and CSS is aware of it. The main test for this selector needed the window named getter for no important reason, so I made a one-line test change to avoid that. Remaining failures in the test are all about SVG elements.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25010

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 28, 2020

⌛ Testing commit c234a6c with merge 0e25eec...
@bors-servo
Copy link
Contributor

bors-servo commented Jan 28, 2020

💔 Test failed - status-taskcluster
@pshaughn
Copy link
Member Author

pshaughn commented Jan 28, 2020

Oh, layout2020 also needs to know about the new enum value, I did not think of that.
@pshaughn pshaughn force-pushed the pshaughn:definedpseudo branch from c234a6c to d687723 Jan 29, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Jan 30, 2020

⌛ Testing commit 8ca4db2 with merge 6882e6b...
bors-servo added a commit that referenced this pull request Jan 30, 2020
@bors-servo
Auto merge of #25627 - pshaughn:definedpseudo, r=emilio,jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6882e6b 
Implement :defined CSS selector

<!-- Please describe your changes on the following line: -->
ElementState::IN_DEFINED_STATE already existed but wasn't hooked up to anything; now it is set appropriately, and CSS is aware of it. The main test for this selector needed the window named getter for no important reason, so I made a one-line test change to avoid that. Remaining failures in the test are all about SVG elements.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25010

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 30, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Jan 31, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jan 31, 2020

⌛ Testing commit 8ca4db2 with merge 9afd163...
bors-servo added a commit that referenced this pull request Jan 31, 2020
@bors-servo
Auto merge of #25627 - pshaughn:definedpseudo, r=emilio,jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9afd163 
Implement :defined CSS selector

<!-- Please describe your changes on the following line: -->
ElementState::IN_DEFINED_STATE already existed but wasn't hooked up to anything; now it is set appropriately, and CSS is aware of it. The main test for this selector needed the window named getter for no important reason, so I made a one-line test change to avoid that. Remaining failures in the test are all about SVG elements.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25010

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 31, 2020

💔 Test failed - status-taskcluster
@CYBAI
Copy link
Collaborator

CYBAI commented Jan 31, 2020

@bors-servo retry

  ▶ PASS [expected FAIL] /_mozilla/css/border-image-linear-gradient.html
bors-servo added a commit that referenced this pull request Jan 31, 2020
@bors-servo
Auto merge of #25627 - pshaughn:definedpseudo, r=emilio,jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4866116 
Implement :defined CSS selector

<!-- Please describe your changes on the following line: -->
ElementState::IN_DEFINED_STATE already existed but wasn't hooked up to anything; now it is set appropriately, and CSS is aware of it. The main test for this selector needed the window named getter for no important reason, so I made a one-line test change to avoid that. Remaining failures in the test are all about SVG elements.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25010

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 31, 2020

⌛ Testing commit 8ca4db2 with merge 4866116...
@bors-servo
Copy link
Contributor

bors-servo commented Jan 31, 2020

💔 Test failed - status-taskcluster
@CYBAI
Copy link
Collaborator

CYBAI commented Jan 31, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jan 31, 2020

⌛ Testing commit 8ca4db2 with merge 4edd159...
bors-servo added a commit that referenced this pull request Jan 31, 2020
@bors-servo
Auto merge of #25627 - pshaughn:definedpseudo, r=emilio,jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4edd159 
Implement :defined CSS selector

<!-- Please describe your changes on the following line: -->
ElementState::IN_DEFINED_STATE already existed but wasn't hooked up to anything; now it is set appropriately, and CSS is aware of it. The main test for this selector needed the window named getter for no important reason, so I made a one-line test change to avoid that. Remaining failures in the test are all about SVG elements.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25010

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 31, 2020

☀️ Test successful - status-taskcluster
Approved by: emilio,jdm
Pushing 4edd159 to master...
@bors-servo bors-servo merged commit 8ca4db2 into servo:master Jan 31, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio

Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

.matches(':defined') on an undefined custom element throws SyntaxError
7 participants
@pshaughn @highfive @servo-wpt-sync @jdm @bors-servo @CYBAI @emilio
You can’t perform that action at this time.