Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Mozilla CSS tests for layout_2020 and add expectations #25630

Merged
merged 1 commit into from Jan 30, 2020
Merged

Enable Mozilla CSS tests for layout_2020 and add expectations #25630

merged 1 commit into from Jan 30, 2020

Conversation

@mrobinson
Copy link
Member

mrobinson commented Jan 28, 2020

This change allows mach to run the Mozilla CSS tests when running with the ``--layout2020` argument. This is useful because we can mark tests as passing as features are added.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because they are tests.
@mrobinson mrobinson requested a review from SimonSapin Jan 28, 2020
@highfive
Copy link

highfive commented Jan 28, 2020

Heads up! This PR modifies the following files:

  • @jgraham: tests/wpt/run.py, tests/wpt/update.py
@SimonSapin
Copy link
Member

SimonSapin commented Jan 28, 2020

Does this not need changes in tests/wpt/include-layout-2020.ini? Does this PR change the number of tests being run by ./mach test-wpt --layout-2020 --release without additional arguments?
@mrobinson mrobinson force-pushed the mrobinson:mozilla-css branch from aad912c to 8259a82 Jan 28, 2020
@mrobinson
Copy link
Member Author

mrobinson commented Jan 28, 2020

@SimonSapin: you're right! I've updated the branch to properly include changes to include-layout-2020.ini.
@SimonSapin
Copy link
Member

SimonSapin commented Jan 28, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 28, 2020

📌 Commit 8259a82 has been approved by SimonSapin
@highfive highfive assigned SimonSapin and unassigned paulrouget Jan 28, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Jan 28, 2020

⌛ Testing commit 8259a82 with merge b10b069...
bors-servo added a commit that referenced this pull request Jan 28, 2020
@bors-servo
Auto merge of #25630 - mrobinson:mozilla-css, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b10b069 
Enable Mozilla CSS tests for layout_2020 and add expectations

This change allows mach to run the Mozilla CSS tests when running with the ``--layout2020` argument. This is useful because we can mark tests as passing as features are added.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because they are tests.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 28, 2020

💔 Test failed - status-taskcluster
@mrobinson
Copy link
Member Author

mrobinson commented Jan 29, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jan 29, 2020

⌛ Testing commit 8259a82 with merge 601cd2c...
bors-servo added a commit that referenced this pull request Jan 29, 2020
@bors-servo
Auto merge of #25630 - mrobinson:mozilla-css, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
601cd2c 
Enable Mozilla CSS tests for layout_2020 and add expectations

This change allows mach to run the Mozilla CSS tests when running with the ``--layout2020` argument. This is useful because we can mark tests as passing as features are added.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because they are tests.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 29, 2020

💔 Test failed - status-taskcluster
@CYBAI
Copy link
Collaborator

CYBAI commented Jan 29, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jan 29, 2020

⌛ Testing commit 50b091d with merge 006b3ce...
bors-servo added a commit that referenced this pull request Jan 29, 2020
@bors-servo
Auto merge of #25630 - mrobinson:mozilla-css, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
006b3ce 
Enable Mozilla CSS tests for layout_2020 and add expectations

This change allows mach to run the Mozilla CSS tests when running with the ``--layout2020` argument. This is useful because we can mark tests as passing as features are added.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because they are tests.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 29, 2020

💔 Test failed - status-taskcluster
@mrobinson
Enable Mozilla CSS tests for layout_2020 and add expectations
Loading status checks…
7cf0710
@mrobinson mrobinson force-pushed the mrobinson:mozilla-css branch from 50b091d to 7cf0710 Jan 29, 2020
@mrobinson
Copy link
Member Author

mrobinson commented Jan 29, 2020

@bors-servo r=SimonSapin

Added failing expectation for input_button_margins_a.html which seems to be a flaky passer.
@bors-servo
Copy link
Contributor

bors-servo commented Jan 29, 2020

📌 Commit 7cf0710 has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Jan 29, 2020

⌛ Testing commit 7cf0710 with merge 26eca46...
bors-servo added a commit that referenced this pull request Jan 29, 2020
@bors-servo
Auto merge of #25630 - mrobinson:mozilla-css, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
26eca46 
Enable Mozilla CSS tests for layout_2020 and add expectations

This change allows mach to run the Mozilla CSS tests when running with the ``--layout2020` argument. This is useful because we can mark tests as passing as features are added.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because they are tests.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 29, 2020

💔 Test failed - status-taskcluster
@CYBAI
Copy link
Collaborator

CYBAI commented Jan 30, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jan 30, 2020

⌛ Testing commit 7cf0710 with merge 912a09c...
bors-servo added a commit that referenced this pull request Jan 30, 2020
@bors-servo
Auto merge of #25630 - mrobinson:mozilla-css, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
912a09c 
Enable Mozilla CSS tests for layout_2020 and add expectations

This change allows mach to run the Mozilla CSS tests when running with the ``--layout2020` argument. This is useful because we can mark tests as passing as features are added.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because they are tests.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 30, 2020

☀️ Test successful - status-taskcluster
Approved by: SimonSapin
Pushing 912a09c to master...
@bors-servo bors-servo merged commit 7cf0710 into servo:master Jan 30, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@mrobinson mrobinson deleted the mrobinson:mozilla-css branch Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonSapin SimonSapin

Assignees

@SimonSapin SimonSapin

Labels
A-layout/2020 A-testing
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@mrobinson @highfive @SimonSapin @bors-servo @CYBAI @paulrouget
You can’t perform that action at this time.