Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement SubmitEvent #25636
Merged
Implement SubmitEvent #25636
Conversation
highfive
commented
Jan 29, 2020
|
Heads up! This PR modifies the following files:
|
|
I took out window-named-getter reliance from a few tests in order to get more meaningful results; they still fail, but now it's for a much more interesting reason and the harness itself doesn't catch an error. |
|
@pshaughn Did you forget to push the updated changes? |
|
Apparently yes. I will get to that! |
|
Error syncing changes upstream. Logs saved in error-snapshot-1580395720500. |
|
OK no the version that changed 4000 files is clearly not the right thing |
|
Opened new PR for upstreamable changes. Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#21513. |
|
I think this is now what I actually meant to push. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 30, 2020
Implement SubmitEvent <!-- Please describe your changes on the following line: --> FormSubmitter was already being passed into submit, so there wasn't much work to do here other than making the new event interface itself. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #24617 <!-- Either: --> - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Jan 31, 2020
Implement SubmitEvent <!-- Please describe your changes on the following line: --> FormSubmitter was already being passed into submit, so there wasn't much work to do here other than making the new event interface itself. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #24617 <!-- Either: --> - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Jan 31, 2020
Implement SubmitEvent <!-- Please describe your changes on the following line: --> FormSubmitter was already being passed into submit, so there wasn't much work to do here other than making the new event interface itself. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #24617 <!-- Either: --> - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Jan 31, 2020
Implement SubmitEvent <!-- Please describe your changes on the following line: --> FormSubmitter was already being passed into submit, so there wasn't much work to do here other than making the new event interface itself. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #24617 <!-- Either: --> - [X] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pshaughn commentedJan 29, 2020
FormSubmitter was already being passed into submit, so there wasn't much work to do here other than making the new event interface itself.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors