Sign UWP packages by default. #25661

jdm · 2020-01-31T08:19:06Z

Signing needs to be disabled when creating packages that are submitted to the MS app store, but it needs to be enabled in order to create packages that can be sideloaded. Since sideloading is the much more common operation, let's turn it on by default and make it possible to opt out of it.

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix #25362
These changes do not require tests because we don't have UWP tests

highfive · 2020-01-31T08:19:11Z

Heads up! This PR modifies the following files:

@wafflespeanut: python/servo/package_commands.py

Manishearth · 2020-01-31T09:51:38Z

@bors-servo r+

bors-servo · 2020-01-31T09:51:39Z

📌 Commit 6a7f26f has been approved by Manishearth

bors-servo · 2020-01-31T10:21:04Z

⌛ Testing commit 6a7f26f with merge 743e627...


        Auto merge of #25661 - jdm:hololens-signing, r=Manishearth

Sign UWP packages by default. Signing needs to be disabled when creating packages that are submitted to the MS app store, but it needs to be enabled in order to create packages that can be sideloaded. Since sideloading is the much more common operation, let's turn it on by default and make it possible to opt out of it. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #25362 - [x] These changes do not require tests because we don't have UWP tests

bors-servo · 2020-01-31T10:45:04Z

💔 Test failed - status-taskcluster

jdm · 2020-01-31T11:05:20Z

         C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\MSBuild\Microsoft\VisualStudio\v15.0\AppxPackage\Microsoft.AppXPackage.Targets(4353,5): error APPX0102: A certificate with thumbprint '45A22CA001C9C6BE412BF449FBE70FEDE635831F' that is specified in the project cannot be found in the certificate store. Please specify a valid thumbprint in the project file. [C:\Users\task_1580457049\repo\support\hololens\ServoApp\ServoApp.vcxproj]
         C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\MSBuild\Microsoft\VisualStudio\v15.0\AppxPackage\Microsoft.AppXPackage.Targets(4353,5): error APPX0107: The certificate specified is not valid for signing. For more information about valid certificates, see http://go.microsoft.com/fwlink/?LinkID=241478. [C:\Users\task_1580457049\repo\support\hololens\ServoApp\ServoApp.vcxproj]

Darkspirit · 2020-01-31T11:12:11Z

Does it need this line back?
https://github.com/servo/servo/pull/25309/files#diff-e1c7e2e1dc4bf7990541ca4a13d15b92L65

jdm · 2020-01-31T11:23:10Z

Good catch!

jdm · 2020-02-12T13:28:09Z

@bors-servo try=windows

bors-servo · 2020-02-12T13:28:15Z

⌛ Trying commit 0bee606 with merge 01e799b...


        Auto merge of #25661 - jdm:hololens-signing, r=<try>

Sign UWP packages by default. Signing needs to be disabled when creating packages that are submitted to the MS app store, but it needs to be enabled in order to create packages that can be sideloaded. Since sideloading is the much more common operation, let's turn it on by default and make it possible to opt out of it. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #25362 - [x] These changes do not require tests because we don't have UWP tests

bors-servo · 2020-02-12T13:44:34Z

💔 Test failed - status-taskcluster


        Auto merge of #25745 - paulrouget:uwptest, r=<try>

make sure UWP app can run This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script. Still need to hook that to our CI.


        Auto merge of #25745 - paulrouget:uwptest, r=<try>

make sure UWP app can run This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script. Still need to hook that to our CI.

paulrouget · 2020-02-14T05:41:05Z

Cannot import the key file 'ServoApp_TemporaryKey.pfx'. The key file may be password protected. To correct this, try to import the certificate manually into the current user's personal certificate store.

Running into that issue as well: #25745

I think that not using a password will solve that specific issue, but installing the certificate (in the Root store) will solve that issue and also the issue we have in #25745.

I don’t know if having a password will cause problems after the certificate has been installed.

@SimonSapin can you help: we need to run:

certutil.exe -addstore "Root" servo/support/hololens/ServoApp/ServoApp_TemporaryKey.pfx


        Auto merge of #25745 - paulrouget:uwptest, r=<try>

make sure UWP app can run Fix #25718 This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script. Still need to hook that to our CI.


        Auto merge of #25745 - paulrouget:uwptest, r=<try>

make sure UWP app can run Fix #25718 This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script. Still need to hook that to our CI.


        Auto merge of #25745 - paulrouget:uwptest, r=<try>

make sure UWP app can run Fix #25718 This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script. Still need to hook that to our CI.


        Auto merge of #25925 - paulrouget:uwpsign, r=<try>

Properly sign UWP package Supersede #25661 Fix #25362 --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #25362 (GitHub issue number if applicable)


        Auto merge of #25925 - paulrouget:uwpsign, r=jdm

Properly sign UWP package Supersede #25661 Fix #25362 --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #25362 (GitHub issue number if applicable)


        Auto merge of #25925 - paulrouget:uwpsign, r=jdm

Properly sign UWP package Supersede #25661 Fix #25362 --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #25362 (GitHub issue number if applicable)


        Auto merge of #25925 - paulrouget:uwpsign, r=jdm

Properly sign UWP package Supersede #25661 Fix #25362 --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #25362 (GitHub issue number if applicable)

bors-servo · 2020-03-09T19:07:05Z

☔ The latest upstream changes (presumably #25925) made this pull request unmergeable. Please resolve the merge conflicts.


        Auto merge of #25745 - paulrouget:uwptest, r=<try>

make sure UWP app can run Fix #25718 This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script. Still need to hook that to our CI.


        Auto merge of #25745 - paulrouget:uwptest, r=<try>

make sure UWP app can run Fix #25718 This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script. Still need to hook that to our CI.


        Auto merge of #25745 - paulrouget:uwptest, r=<try>

make sure UWP app can run Fix #25718 This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script. Still need to hook that to our CI.


        Auto merge of #25745 - paulrouget:uwptest, r=<try>

make sure UWP app can run Fix #25718 This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script. Still need to hook that to our CI.


        Auto merge of #25745 - paulrouget:uwptest, r=<try>

make sure UWP app can run Fix #25718 This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script. Still need to hook that to our CI.


        Auto merge of #25745 - paulrouget:uwptest, r=<try>

make sure UWP app can run Fix #25718 This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script. Still need to hook that to our CI.


        Auto merge of #25745 - paulrouget:uwptest, r=<try>

make sure UWP app can run Fix #25718 This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script. Still need to hook that to our CI.


        Auto merge of #25745 - paulrouget:uwptest, r=<try>

make sure UWP app can run Fix #25718 This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script. Still need to hook that to our CI.


        Auto merge of #25745 - paulrouget:uwptest, r=<try>

make sure UWP app can run Fix #25718 This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script. Still need to hook that to our CI.


        Auto merge of #25745 - paulrouget:uwptest, r=<try>

make sure UWP app can run Fix #25718 This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script. Still need to hook that to our CI.


        Auto merge of #25745 - paulrouget:uwptest, r=<try>

make sure UWP app can run Fix #25718 This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script. Still need to hook that to our CI.


        Auto merge of #25745 - paulrouget:uwptest, r=<try>

make sure UWP app can run Fix #25718 This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script. Still need to hook that to our CI.


        Auto merge of #25745 - paulrouget:uwptest, r=<try>

make sure UWP app can run Fix #25718 This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script. Still need to hook that to our CI.


        Auto merge of #25745 - paulrouget:uwptest, r=<try>

make sure UWP app can run Fix #25718 This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script. Still need to hook that to our CI.


        Auto merge of #25745 - paulrouget:uwptest, r=<try>

make sure UWP app can run Fix #25718 This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script. Still need to hook that to our CI.


        Auto merge of #25745 - paulrouget:uwptest, r=<try>

make sure UWP app can run Fix #25718 This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script. Still need to hook that to our CI.


        Auto merge of #25745 - paulrouget:uwptest, r=<try>

make sure UWP app can run Fix #25718 This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script. Still need to hook that to our CI.


        Auto merge of #25745 - paulrouget:uwptest, r=<try>

make sure UWP app can run Fix #25718 This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script. Still need to hook that to our CI.


        Auto merge of #25745 - paulrouget:uwptest, r=<try>

make sure UWP app can run Fix #25718 This includes #25661 with some minor tweaks (certificate file reference was missing, and its id was wrong) and a python script. Still need to hook that to our CI.

highfive assigned Manishearth Jan 31, 2020

highfive added the S-awaiting-review label Jan 31, 2020

Manishearth approved these changes Jan 31, 2020

View changes

highfive added S-awaiting-merge and removed S-awaiting-review labels Jan 31, 2020

highfive added S-tests-failed and removed S-awaiting-merge labels Jan 31, 2020

paulrouget mentioned this pull request Feb 12, 2020

Add UWP smoketest to CI #25718

Open

jdm force-pushed the jdm:hololens-signing branch from 6a7f26f to 7686c77 Feb 12, 2020

highfive added S-awaiting-review and removed S-tests-failed labels Feb 12, 2020

highfive added the S-tests-failed label Feb 12, 2020

paulrouget mentioned this pull request Feb 12, 2020

make sure UWP app can run #25745

Open

paulrouget mentioned this pull request Feb 14, 2020

Adjust UWP packaging for submission (bis) #25762

Closed

paulrouget mentioned this pull request Mar 9, 2020

Properly sign UWP package #25925

Merged

3 of 3 tasks complete

highfive added the S-needs-rebase label Mar 9, 2020

jdm closed this Mar 9, 2020

servo / servo

Sign UWP packages by default. #25661

Sign UWP packages by default. #25661

jdm commented Jan 31, 2020

highfive commented Jan 31, 2020

Manishearth commented Jan 31, 2020

bors-servo commented Jan 31, 2020

bors-servo commented Jan 31, 2020

bors-servo commented Jan 31, 2020

jdm commented Jan 31, 2020

Darkspirit commented Jan 31, 2020 •

edited

jdm commented Jan 31, 2020

jdm commented Feb 12, 2020

bors-servo commented Feb 12, 2020

bors-servo commented Feb 12, 2020

paulrouget commented Feb 14, 2020

bors-servo commented Mar 9, 2020

servo / servo

Join GitHub today

Sign UWP packages by default. #25661

Sign UWP packages by default. #25661

Conversation

jdm commented Jan 31, 2020

highfive commented Jan 31, 2020

Manishearth commented Jan 31, 2020

bors-servo commented Jan 31, 2020

bors-servo commented Jan 31, 2020

bors-servo commented Jan 31, 2020

jdm commented Jan 31, 2020

Darkspirit commented Jan 31, 2020 • edited

jdm commented Jan 31, 2020

jdm commented Feb 12, 2020

bors-servo commented Feb 12, 2020

bors-servo commented Feb 12, 2020

paulrouget commented Feb 14, 2020

bors-servo commented Mar 9, 2020

Darkspirit commented Jan 31, 2020 •

edited