Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill off hanging crashtests. #25670

Merged
merged 1 commit into from Feb 1, 2020
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Kill off hanging crashtests.

  • Loading branch information
jdm committed Feb 1, 2020
commit 44a2953e84b41246a83326dbb1f9830ecb584afb
"support"
],
"tools/wptrunner/wptrunner/executors/executorservo.py": [
"8f8e120e66da6403f256f99f279f1f5dc8008272",
"4816c3df06e87f8e85301918c341bbff97817777",
"support"
],
"tools/wptrunner/wptrunner/executors/executorservodriver.py": [
@@ -332,6 +332,8 @@ def do_test(self, test):
self.test = test
success, data = ServoTimedRunner(self.logger, self.do_crashtest, self.protocol,
test_url, timeout, self.extra_timeout).run()
# Ensure that no processes hang around if they timeout.
self.proc.kill()

if success:
return self.convert_result(test, data)
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.