Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow embedders to provide user agent string #25672

Closed
wants to merge 8 commits into from

Fix passing of user_agent to create_constellation

  • Loading branch information
mediremi committed Feb 1, 2020
commit fe744f5792927a689f91be74e4ea1019be44575e
@@ -506,7 +506,7 @@ where
// pipelines, including the script and layout threads, as well
// as the navigation context.
let (constellation_chan, sw_senders) = create_constellation(
embedder.default_user_agent_string.clone(),
embedder.default_user_agent_string().into(),
opts.config_dir.clone(),
embedder_proxy.clone(),
compositor_proxy.clone(),
@@ -857,7 +857,7 @@ fn create_constellation(
BluetoothThreadFactory::new(embedder_proxy.clone());

let (public_resource_threads, private_resource_threads) = new_resource_threads(
user_agent,
user_agent.clone(),
devtools_chan.clone(),
time_profiler_chan.clone(),
mem_profiler_chan.clone(),
@@ -891,6 +891,7 @@ fn create_constellation(
glplayer_threads,
player_context,
event_loop_waker,
user_agent,
};
let (constellation_chan, from_swmanager_sender) = Constellation::<
script_layout_interface::message::Msg,
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.