Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFilter file: and about: responses opaquely #25687
Merged
Conversation
highfive
commented
Feb 4, 2020
|
Heads up! This PR modifies the following files:
|
highfive
commented
Feb 4, 2020
|
|
|
@bors-servo try=wpt |
bors-servo
added a commit
that referenced
this pull request
Feb 4, 2020
Try removing "file" and "about" from taint-exceptions, see what results <!-- Please describe your changes on the following line: --> Best-case scenario: fix #25686 Expected outcome: find out which test the comment on the code I deleted was referring to. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
Two unit test failures, the important part of the stack trace being: WPT failures: |
pshaughn
changed the title
pshaughn
force-pushed the
pshaughn:taintfile
branch
2 times, most recently
from
bb1a3b4
to
4f5edf0
|
I apparently did not push the same unit tests I was actually running and I need to detangle that |
pshaughn
force-pushed the
pshaughn:taintfile
branch
2 times, most recently
from
7f8b7a9
to
9ca8f36
|
|
|
I'm pleased that we can remove this special case now! |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 11, 2020
Filter file: and about: responses opaquely <!-- Please describe your changes on the following line: --> file: and about: schemes were being treated like data: for cors purposes, when in fact they should have been subject to opaque response filtering. A comment indicated that this was necessary for some CSS tests, but I think the comment was out of date; the only tests depending on the unfiltered responses are unit tests that do not test any CSS functionality. I've updated those tests to now test for the opaque-filtering itself. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #25686 <!-- Either: --> - [X] There are tests for these changes, but also some loss of unit test coverage (#25693) and a newly failing test case (#25692) <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
I haven't seen those before, but I can't think of any way an OfflineAudioContext would be trying to open a file: or about: url so they're probably unrelated? |
|
@bors-servo retry Indeed! |
bors-servo
added a commit
that referenced
this pull request
Feb 11, 2020
Filter file: and about: responses opaquely <!-- Please describe your changes on the following line: --> file: and about: schemes were being treated like data: for cors purposes, when in fact they should have been subject to opaque response filtering. A comment indicated that this was necessary for some CSS tests, but I think the comment was out of date; the only tests depending on the unfiltered responses are unit tests that do not test any CSS functionality. I've updated those tests to now test for the opaque-filtering itself. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #25686 <!-- Either: --> - [X] There are tests for these changes, but also some loss of unit test coverage (#25693) and a newly failing test case (#25692) <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pshaughn commentedFeb 4, 2020
•
edited
file: and about: schemes were being treated like data: for cors purposes, when in fact they should have been subject to opaque response filtering. A comment indicated that this was necessary for some CSS tests, but I think the comment was out of date; the only tests depending on the unfiltered responses are unit tests that do not test any CSS functionality. I've updated those tests to now test for the opaque-filtering itself.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors