Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated comment about #4105 #25696

Merged
merged 1 commit into from Feb 6, 2020
Merged

Remove outdated comment about #4105 #25696

merged 1 commit into from Feb 6, 2020

Conversation

@pshaughn
Copy link
Member

pshaughn commented Feb 5, 2020

Just taking out a comment for an issue that had already been resolved.
@pshaughn
Remove outdated comment about #4105
Loading status checks…
4ea0a70
@highfive
Copy link

highfive commented Feb 5, 2020

Heads up! This PR modifies the following files:
@highfive
Copy link

highfive commented Feb 5, 2020

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@Manishearth
Copy link
Member

Manishearth commented Feb 5, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Feb 5, 2020

📌 Commit 4ea0a70 has been approved by Manishearth
@highfive highfive assigned Manishearth and unassigned paulrouget Feb 5, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Feb 5, 2020

⌛ Testing commit 4ea0a70 with merge 6e99e32...
bors-servo added a commit that referenced this pull request Feb 5, 2020
@bors-servo
Auto merge of #25696 - pshaughn:4105comment, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6e99e32 
Remove outdated comment about #4105

<!-- Please describe your changes on the following line: -->
Just taking out a comment for an issue that had already been resolved.
@bors-servo
Copy link
Contributor

bors-servo commented Feb 6, 2020

💔 Test failed - status-taskcluster
@CYBAI
Copy link
Collaborator

CYBAI commented Feb 6, 2020

@bors-servo retry
bors-servo added a commit that referenced this pull request Feb 6, 2020
@bors-servo
Auto merge of #25696 - pshaughn:4105comment, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5ef30c6 
Remove outdated comment about #4105

<!-- Please describe your changes on the following line: -->
Just taking out a comment for an issue that had already been resolved.
@bors-servo
Copy link
Contributor

bors-servo commented Feb 6, 2020

⌛ Testing commit 4ea0a70 with merge 5ef30c6...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 6, 2020

☀️ Test successful - status-taskcluster
Approved by: Manishearth
Pushing 5ef30c6 to master...
@bors-servo bors-servo merged commit 4ea0a70 into servo:master Feb 6, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@pshaughn @highfive @Manishearth @bors-servo @CYBAI @paulrouget
You can’t perform that action at this time.