Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix timeout vs. task-queue race conditions in promise rejection tests #25698
Conversation
|
Opened new PR for upstreamable changes. Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#21618. |
|
Transplanted upstreamable changes to existing PR. Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#21618. |
|
Great catch! |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 10, 2020
Fix timeout vs. task-queue race conditions in promise rejection tests <!-- Please describe your changes on the following line: --> These two tests were assuming that timeouts and promise rejection events would have a temporal relationship not actually guaranteed by spec, leading to test timeouts if the DOM manipulation task queue was running slower than anticipated. fix #22207, fix #22295 Of course, the upstream WPT results need looking at to be sure this hasn't done something weird to another browser.
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Feb 10, 2020
Fix timeout vs. task-queue race conditions in promise rejection tests <!-- Please describe your changes on the following line: --> These two tests were assuming that timeouts and promise rejection events would have a temporal relationship not actually guaranteed by spec, leading to test timeouts if the DOM manipulation task queue was running slower than anticipated. fix #22207, fix #22295 Of course, the upstream WPT results need looking at to be sure this hasn't done something weird to another browser.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pshaughn commentedFeb 6, 2020
These two tests were assuming that timeouts and promise rejection events would have a temporal relationship not actually guaranteed by spec, leading to test timeouts if the DOM manipulation task queue was running slower than anticipated.
fix #22207, fix #22295
Of course, the upstream WPT results need looking at to be sure this hasn't done something weird to another browser.