Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments linking to the steps of the specs in the checks on Location setters #25714

Closed
wants to merge 9 commits into from
Closed

Add comments linking to the steps of the specs in the checks on Location setters #25714

wants to merge 9 commits into from
+33 −37

Commits on Jun 30, 2019

  1. only allow http/https protocols

    @braddunbar
    braddunbar committed Jun 30, 2019
    Verified
    This commit was signed with a verified signature.
    braddunbar Brad Dunbar
    GPG key ID: C32E3CC9B201C719 Learn about signing commits
    9845249

  2. host or hostname: abort if url cannot be a base

    @braddunbar
    braddunbar committed Jun 30, 2019
    Verified
    This commit was signed with a verified signature.
    braddunbar Brad Dunbar
    GPG key ID: C32E3CC9B201C719 Learn about signing commits
    3c8df69

  3. port: abort if url cannot have username/password/port

    @braddunbar
    braddunbar committed Jun 30, 2019
    Verified
    This commit was signed with a verified signature.
    braddunbar Brad Dunbar
    GPG key ID: C32E3CC9B201C719 Learn about signing commits
    97e967c

  4. pathname: terminate if cannot-be-a-base

    @braddunbar
    braddunbar committed Jun 30, 2019
    Verified
    This commit was signed with a verified signature.
    braddunbar Brad Dunbar
    GPG key ID: C32E3CC9B201C719 Learn about signing commits
    3f2abcc

Commits on Jul 1, 2019

  1. remove failure expectations

    @braddunbar
    braddunbar committed Jul 1, 2019
    Loading status checks…
    Verified
    This commit was signed with a verified signature.
    braddunbar Brad Dunbar
    GPG key ID: C32E3CC9B201C719 Learn about signing commits
    6c31813

  2. link to cannot have a username password spec

    @braddunbar
    braddunbar committed Jul 1, 2019
    Loading status checks…
    Verified
    This commit was signed with a verified signature.
    braddunbar Brad Dunbar
    GPG key ID: C32E3CC9B201C719 Learn about signing commits
    05f7547

Commits on Feb 9, 2020

  1. fix merge conflict

    @UxioAndrade
    UxioAndrade committed Feb 9, 2020
    214fbc9

  2. add comments linking to steps of the specs

    @UxioAndrade
    UxioAndrade committed Feb 9, 2020
    Loading status checks…
    ad31fde

Commits on Feb 10, 2020

  1. change scheme unwrap into syntax error

    @UxioAndrade
    UxioAndrade committed Feb 10, 2020
    Loading status checks…
    ec77231
You can’t perform that action at this time.