Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments linking to the steps of the specs in the checks on Location setters #25714

Closed
wants to merge 9 commits into from
+33 −37
Closed

Add comments linking to the steps of the specs in the checks on Location setters #25714

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9845249
only allow http/https protocols
braddunbar Jun 29, 2019
3c8df69
host or hostname: abort if url cannot be a base
braddunbar Jun 30, 2019
97e967c
port: abort if url cannot have username/password/port
braddunbar Jun 30, 2019
3f2abcc
pathname: terminate if cannot-be-a-base
braddunbar Jun 30, 2019
6c31813
remove failure expectations
braddunbar Jul 1, 2019
05f7547
link to cannot have a username password spec
braddunbar Jul 1, 2019
214fbc9
fix merge conflict
UxioAndrade Feb 9, 2020
ad31fde
add comments linking to steps of the specs
UxioAndrade Feb 9, 2020
ec77231
change scheme unwrap into syntax error
UxioAndrade Feb 10, 2020
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Next

only allow http/https protocols

  • Loading branch information
@braddunbar
braddunbar committed Jun 30, 2019
Verified
This commit was signed with a verified signature.
braddunbar Brad Dunbar
GPG key ID: C32E3CC9B201C719 Learn about signing commits
commit 98452495dd63a121e8e6d14386a26c0b628a52e8
6 components/script/dom/location.rs
View file
Open in desktop
@@ -217,7 +217,11 @@ impl LocationMethods for Location {
// https://html.spec.whatwg.org/multipage/#dom-location-protocol
fn SetProtocol(&self, value: USVString) -> ErrorResult {
self.check_same_origin_domain()?;
self.set_url_component(value, UrlHelper::SetProtocol);
// If copyURL's scheme is not an HTTP(S) scheme, then terminate these steps.
let scheme = value.split(':').next().unwrap();

This comment has been minimized.

Sign in to view
Copy link
@paulrouget

paulrouget Feb 10, 2020

Contributor

Isn’t it dangerous to have unwrap() here?

This comment has been minimized.

Sign in to view
Copy link
@gterzian

gterzian Feb 10, 2020 •
edited

Member

Yes you're right, actually per Step 5 of the protocol setter spec, I think we should return a Error::Syntax here instead of unwrap, see https://html.spec.whatwg.org/multipage/history.html#dom-location-protocol

This would be using use crate::dom::bindings::error::Error;

This comment has been minimized.

Sign in to view
Copy link
@UxioAndrade

UxioAndrade Feb 10, 2020

Author

Would my latest commit fix that?

This comment has been minimized.

Sign in to view
Copy link
@gterzian

gterzian Feb 10, 2020

Member

Yes.

Please run ./mach fmt to fix https://community-tc.services.mozilla.com/tasks/VcHxks51RSywXhLH0W3dXg/runs/0/logs/https%3A%2F%2Fcommunity-tc.services.mozilla.com%2Fapi%2Fqueue%2Fv1%2Ftask%2FVcHxks51RSywXhLH0W3dXg%2Fruns%2F0%2Fartifacts%2Fpublic%2Flogs%2Flive.log

And please also squash...
if scheme.eq_ignore_ascii_case("http") || scheme.eq_ignore_ascii_case("https") {
self.set_url_component(value, UrlHelper::SetProtocol);
}
Ok(())
}

16 ...html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html.ini
View file
Open in desktop
@@ -17,19 +17,3 @@

[Set data URL frame location.protocol to http+x]
expected: FAIL

[Set HTTP URL frame location.protocol to gopher]
expected: FAIL

[Set HTTP URL frame location.protocol to http+x]
expected: FAIL

[Set HTTP URL frame location.protocol to ftp]
expected: FAIL

[Set HTTP URL frame location.protocol to data]
expected: FAIL

[Set HTTP URL frame location.protocol to x]
expected: FAIL

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.