New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add comments linking to the steps of the specs in the checks on Location setters #25714
Closed
+33
−37
Closed
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
9845249
only allow http/https protocols
braddunbar 3c8df69
host or hostname: abort if url cannot be a base
braddunbar 97e967c
port: abort if url cannot have username/password/port
braddunbar 3f2abcc
pathname: terminate if cannot-be-a-base
braddunbar 6c31813
remove failure expectations
braddunbar 05f7547
link to cannot have a username password spec
braddunbar 214fbc9
fix merge conflict
UxioAndrade ad31fde
add comments linking to steps of the specs
UxioAndrade ec77231
change scheme unwrap into syntax error
UxioAndrade File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.
Loading status checks…
change scheme unwrap into syntax error
- Loading branch information
commit ec7723142efc30b083a7c4e44f2fe2448041cc45
ProTip!
Use n and p to navigate between commits in a pull request.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Here we can put a comment for Step 5, throw a "SyntaxError" DOMException.