Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert ANGLE upgrade. #25716

Merged
merged 1 commit into from Feb 10, 2020
Merged

Revert ANGLE upgrade. #25716

merged 1 commit into from Feb 10, 2020

Conversation

@jdm
Copy link
Member

jdm commented Feb 10, 2020

This reverts commit ce6204b, reversing
changes made to 904fcb4.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #25683
@jdm
Revert "Auto merge of #25509 - jdm:angle-up, r=asajeffrey"
Loading status checks…
4a4b8bd 
This reverts commit ce6204b, reversing
changes made to 904fcb4.
@highfive
Copy link

highfive commented Feb 10, 2020

Heads up! This PR modifies the following files:
@jdm
Copy link
Member Author

jdm commented Feb 10, 2020

@bors-servo r+ p=2
@bors-servo
Copy link
Contributor

bors-servo commented Feb 10, 2020

📌 Commit 4a4b8bd has been approved by jdm
@highfive highfive assigned jdm and unassigned Manishearth Feb 10, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Feb 10, 2020

⌛ Testing commit 4a4b8bd with merge daf0375...
bors-servo added a commit that referenced this pull request Feb 10, 2020
@bors-servo
Auto merge of #25716 - jdm:revert-angle-up, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
daf0375 
Revert ANGLE upgrade.

This reverts commit ce6204b, reversing
changes made to 904fcb4.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #25683
@bors-servo
Copy link
Contributor

bors-servo commented Feb 10, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented Feb 10, 2020

@bors-servo retry
bors-servo added a commit that referenced this pull request Feb 10, 2020
@bors-servo
Auto merge of #25716 - jdm:revert-angle-up, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
39133ee 
Revert ANGLE upgrade.

This reverts commit ce6204b, reversing
changes made to 904fcb4.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #25683
@bors-servo
Copy link
Contributor

bors-servo commented Feb 10, 2020

⌛ Testing commit 4a4b8bd with merge 39133ee...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 10, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 39133ee to master...
@bors-servo bors-servo merged commit 4a4b8bd into servo:master Feb 10, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Feb 10, 2020
Closed
3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

UWP: Unable to activate Windows Store App
4 participants
@jdm @highfive @bors-servo @Manishearth
You can’t perform that action at this time.