Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CanvasRenderingContext2D.getTransform() #25734

Merged
merged 1 commit into from Feb 13, 2020
Merged

Implement CanvasRenderingContext2D.getTransform() #25734

merged 1 commit into from Feb 13, 2020

Conversation

@pylbrecht
Copy link
Contributor

pylbrecht commented Feb 11, 2020

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix part of #25331
  • There are tests for these changes
@highfive
Copy link

highfive commented Feb 11, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/paintrenderingcontext2d.rs, components/script/dom/webidls/DOMMatrix.webidl, components/script/dom/canvasrenderingcontext2d.rs, components/script/canvas_state.rs, components/script/dom/webidls/DOMMatrixReadOnly.webidl and 4 more
  • @KiChjang: components/script/dom/paintrenderingcontext2d.rs, components/script/dom/webidls/DOMMatrix.webidl, components/script/dom/canvasrenderingcontext2d.rs, components/script/canvas_state.rs, components/script/dom/webidls/DOMMatrixReadOnly.webidl and 4 more
@pylbrecht
Copy link
Contributor Author

pylbrecht commented Feb 11, 2020

r? @jdm
@highfive highfive assigned jdm and unassigned asajeffrey Feb 11, 2020
@pylbrecht
Copy link
Contributor Author

pylbrecht commented Feb 11, 2020

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Feb 11, 2020

⌛ Trying commit 280e25e with merge a769e1d...
bors-servo added a commit that referenced this pull request Feb 11, 2020
@bors-servo
Auto merge of #25734 - pylbrecht:get.transform, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a769e1d 
Implement CanvasRenderingContext2D.getTransform()

<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix part of #25331

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@jdm
jdm approved these changes Feb 11, 2020
View changes
@bors-servo
Copy link
Contributor

bors-servo commented Feb 11, 2020

💔 Test failed - status-taskcluster
@pylbrecht pylbrecht force-pushed the pylbrecht:get.transform branch from 280e25e to 3bd7599 Feb 11, 2020
@pylbrecht
Copy link
Contributor Author

pylbrecht commented Feb 11, 2020

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Feb 11, 2020

⌛ Trying commit 3bd7599 with merge d368309...
bors-servo added a commit that referenced this pull request Feb 11, 2020
@bors-servo
Auto merge of #25734 - pylbrecht:get.transform, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d368309 
Implement CanvasRenderingContext2D.getTransform()

<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix part of #25331

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@pylbrecht pylbrecht force-pushed the pylbrecht:get.transform branch from 3bd7599 to 2ba5478 Feb 11, 2020
@pylbrecht
Copy link
Contributor Author

pylbrecht commented Feb 11, 2020

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Feb 11, 2020

⌛ Trying commit 2ba5478 with merge 2f0744c...
bors-servo added a commit that referenced this pull request Feb 11, 2020
@bors-servo
Auto merge of #25734 - pylbrecht:get.transform, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2f0744c 
Implement CanvasRenderingContext2D.getTransform()

<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix part of #25331

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 11, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Feb 12, 2020 

  ▶ Unexpected subtest result in /html/dom/idlharness.https.html?exclude=(Document|Window|HTML.*):
  └ PASS [expected FAIL] CanvasRenderingContext2D interface: operation getTransform()
  ▶ Unexpected subtest result in /html/dom/idlharness.https.html?exclude=(Document|Window|HTML.*):
  └ PASS [expected FAIL] CanvasRenderingContext2D interface: document.createElement("canvas").getContext("2d") must inherit property "getTransform()" with the proper type
@pylbrecht
Implement CanvasRenderingContext2D.getTransform()
Loading status checks…
588c09b
@pylbrecht pylbrecht force-pushed the pylbrecht:get.transform branch from 2ba5478 to 588c09b Feb 12, 2020
@pylbrecht
Copy link
Contributor Author

pylbrecht commented Feb 12, 2020

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Feb 12, 2020

⌛ Trying commit 588c09b with merge 1c48ff6...
bors-servo added a commit that referenced this pull request Feb 12, 2020
@bors-servo
Auto merge of #25734 - pylbrecht:get.transform, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1c48ff6 
Implement CanvasRenderingContext2D.getTransform()

<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix part of #25331

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@jdm
Copy link
Member

jdm commented Feb 12, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 12, 2020

⌛ Testing commit 588c09b with merge a63a23b...
bors-servo added a commit that referenced this pull request Feb 12, 2020
@bors-servo
Auto merge of #25734 - pylbrecht:get.transform, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a63a23b 
Implement CanvasRenderingContext2D.getTransform()

<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix part of #25331

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 12, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Feb 12, 2020

@bors-servo retry
bors-servo added a commit that referenced this pull request Feb 13, 2020
@bors-servo
Auto merge of #25734 - pylbrecht:get.transform, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
21ef69d 
Implement CanvasRenderingContext2D.getTransform()

<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix part of #25331

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 13, 2020

⌛ Testing commit 588c09b with merge 21ef69d...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 13, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Feb 13, 2020

@bors-servo retry
@pylbrecht
Copy link
Contributor Author

pylbrecht commented Feb 13, 2020

@bors-servo try=wpt
bors-servo added a commit that referenced this pull request Feb 13, 2020
@bors-servo
Auto merge of #25734 - pylbrecht:get.transform, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a43d76b 
Implement CanvasRenderingContext2D.getTransform()

<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix part of #25331

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 13, 2020

⌛ Trying commit 588c09b with merge a43d76b...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 13, 2020

☀️ Test successful - status-taskcluster
State: approved=jdm try=True
bors-servo added a commit that referenced this pull request Feb 13, 2020
@bors-servo
Auto merge of #25734 - pylbrecht:get.transform, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2c70db5 
Implement CanvasRenderingContext2D.getTransform()

<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix part of #25331

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 13, 2020

⌛ Testing commit 588c09b with merge 2c70db5...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 13, 2020

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 2c70db5 to master...
@bors-servo bors-servo merged commit 588c09b into servo:master Feb 13, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@pylbrecht @highfive @bors-servo @jdm @asajeffrey
You can’t perform that action at this time.