Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to rustc 1.43.0-nightly (5d04ce67f 2020-02-13) #25739

Merged
merged 2 commits into from Feb 14, 2020
Merged

Upgrade to rustc 1.43.0-nightly (5d04ce67f 2020-02-13) #25739

merged 2 commits into from Feb 14, 2020

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Feb 12, 2020

This Nightly doesn’t have rustfmt, so merging this PR is blocked on rust-lang/rust#68917 and upgrading to a Nightly with the fix.

Fixes #25550

@SimonSapin SimonSapin force-pushed the rustup branch from fcfd9b3 to dd9521b Feb 14, 2020
@SimonSapin SimonSapin changed the title [Not mergeable yet] Upgrade to rustc 1.43.0-nightly (fc23a8183 2020-02-11) Upgrade to rustc 1.43.0-nightly (5d04ce67f 2020-02-13) Feb 14, 2020
@paulrouget
Copy link
Contributor

paulrouget commented Feb 14, 2020

r=me

Some warning though:

warning: unnecessary parentheses around block return value                                                  
   --> components/layout/fragment.rs:947:13                                                                 
    |
947 | /             (MaybeAuto::from_style(margin.inline_start, Au(0)).specified_or_zero() +                
948 | |                 MaybeAuto::from_style(margin.inline_end, Au(0)).specified_or_zero())                
    | |____________________________________________________________________________________^                
    |
    = note: `#[warn(unused_parens)]` on by default                                                          
help: remove these parentheses
    |
947 |             MaybeAuto::from_style(margin.inline_start, Au(0)).specified_or_zero() +                   
948 |                 MaybeAuto::from_style(margin.inline_end, Au(0)).specified_or_zero()                   
    |
warning: unnecessary parentheses around block return value                                                  
   --> components/layout/fragment.rs:960:13
    |
960 |             (padding.inline_start.to_used_value(Au(0)) + padding.inline_end.to_used_value(Au(0)))     
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help:
 remove these parentheses
@nox nox force-pushed the rustup branch from dd9521b to 28f1f8f Feb 14, 2020
@nox
Copy link
Member

nox commented Feb 14, 2020

I fixed it.

@bors-servo r=paulrouget

@bors-servo
Copy link
Contributor

bors-servo commented Feb 14, 2020

📌 Commit 28f1f8f has been approved by paulrouget

@bors-servo
Copy link
Contributor

bors-servo commented Feb 14, 2020

Testing commit 28f1f8f with merge f68551e...

bors-servo added a commit that referenced this pull request Feb 14, 2020
Upgrade to rustc 1.43.0-nightly (5d04ce67f 2020-02-13)

~This Nightly doesn’t have rustfmt, so merging this PR is blocked on rust-lang/rust#68917 and upgrading to a Nightly with the fix.~
@paulrouget
Copy link
Contributor

paulrouget commented Feb 14, 2020

Fix #25550

@SimonSapin
Copy link
Member Author

SimonSapin commented Feb 14, 2020

That only works in the PR description (or commit messages), I’ve added it.

@bors-servo
Copy link
Contributor

bors-servo commented Feb 14, 2020

💔 Test failed - status-taskcluster

@nox
Copy link
Member

nox commented Feb 14, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Feb 14, 2020

Testing commit 28f1f8f with merge 53d130b...

bors-servo added a commit that referenced this pull request Feb 14, 2020
Upgrade to rustc 1.43.0-nightly (5d04ce67f 2020-02-13)

~This Nightly doesn’t have rustfmt, so merging this PR is blocked on rust-lang/rust#68917 and upgrading to a Nightly with the fix.~

Fixes #25550
@SimonSapin
Copy link
Member Author

SimonSapin commented Feb 14, 2020

Fixed some Windows-only warnings:

error: unnecessary parentheses around block return value
   --> components\gfx\platform\windows\font.rs:138:21
    |
138 |                     ((family, face))
    |                     ^^^^^^^^^^^^^^^^ help: remove these parentheses
    |
    = note: `-D unused-parens` implied by `-D warnings`
error: unnecessary parentheses around block return value
   --> components\gfx\platform\windows\font.rs:148:21
    |
148 |                     ((family, face))
    |                     ^^^^^^^^^^^^^^^^ help: remove these parentheses

@bors-servo r=paulrouget

@bors-servo
Copy link
Contributor

bors-servo commented Feb 14, 2020

📌 Commit 708d373 has been approved by paulrouget

@bors-servo
Copy link
Contributor

bors-servo commented Feb 14, 2020

💔 Test failed - status-taskcluster

@SimonSapin
Copy link
Member Author

SimonSapin commented Feb 14, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Feb 14, 2020

Testing commit 708d373 with merge 24de9a1...

bors-servo added a commit that referenced this pull request Feb 14, 2020
Upgrade to rustc 1.43.0-nightly (5d04ce67f 2020-02-13)

~This Nightly doesn’t have rustfmt, so merging this PR is blocked on rust-lang/rust#68917 and upgrading to a Nightly with the fix.~

Fixes #25550
@bors-servo
Copy link
Contributor

bors-servo commented Feb 14, 2020

💔 Test failed - status-taskcluster

@SimonSapin
Copy link
Member Author

SimonSapin commented Feb 14, 2020

Sighs

@bors-servo retry #24726

@bors-servo
Copy link
Contributor

bors-servo commented Feb 14, 2020

Testing commit 708d373 with merge 3f054d9...

bors-servo added a commit that referenced this pull request Feb 14, 2020
Upgrade to rustc 1.43.0-nightly (5d04ce67f 2020-02-13)

~This Nightly doesn’t have rustfmt, so merging this PR is blocked on rust-lang/rust#68917 and upgrading to a Nightly with the fix.~

Fixes #25550
@bors-servo
Copy link
Contributor

bors-servo commented Feb 14, 2020

💔 Test failed - status-taskcluster

@jdm
Copy link
Member

jdm commented Feb 14, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Feb 14, 2020

Testing commit 708d373 with merge 55473eb...

bors-servo added a commit that referenced this pull request Feb 14, 2020
Upgrade to rustc 1.43.0-nightly (5d04ce67f 2020-02-13)

~This Nightly doesn’t have rustfmt, so merging this PR is blocked on rust-lang/rust#68917 and upgrading to a Nightly with the fix.~

Fixes #25550
@bors-servo
Copy link
Contributor

bors-servo commented Feb 14, 2020

☀️ Test successful - status-taskcluster
Approved by: paulrouget
Pushing 55473eb to master...

@bors-servo bors-servo merged commit 708d373 into master Feb 14, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@bors-servo bors-servo deleted the rustup branch Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

6 participants
You can’t perform that action at this time.