Add new Servo Logo

[malqinneh]

• Added servo-64.png (replacing servo64.png @ 64px)
• Added servo-100.png (replacing doge-tiny.png @ 100px)
• Added servo-500.png
• Added servo-500-icon.ico
• Added servo-1000.png (replacing servo.png @ 1000px)
• Added servo.svg (replacing servo.svg)

---

• ./mach build -d does not report any errors
• ./mach test-tidy does not report any errors
• These changes fix #___ (GitHub issue number if applicable)

• There are tests for these changes OR
• These changes do not require tests because they add new logo assets

[highfive]

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @nox (or someone else) soon.

[paulrouget]

Can you also update support/android/apk/servoapp/src/main/res/mipmap/servo.png ?

[malqinneh]

Can you also update support/android/apk/servoapp/src/main/res/mipmap/servo.png ?

Absolutely ✅

[paulrouget]

@jdm do we want to land that now?

[jdm]

@bors-servo r+
Thanks @malqinneh!

[bors-servo]

📌 Commit 5314625 has been approved by jdm

[bors-servo]

⌛ Testing commit 5314625 with merge 06678e7...

[bors-servo]

💔 Test failed - status-taskcluster

[jdm]

> /repo/support/android/apk/servoapp/src/main/res/mipmap/servo-1024.png: Error: '-' is not a valid file-based resource name character: File-based resource names must contain only lowercase a-z, 0-9, or underscore

[malqinneh]

> /repo/support/android/apk/servoapp/src/main/res/mipmap/servo-1024.png: Error: '-' is not a valid file-based resource name character: File-based resource names must contain only lowercase a-z, 0-9, or underscore

Is this a matter of replacing - (dash) with _ (underscore) in the filename?

[jdm]

I expect that would work, but we should really overwrite the existing servo.png instead so that the new image gets used automatically.

[malqinneh]

I expect that would work, but we should really overwrite the existing servo.png instead so that the new image gets used automatically.

Makes sense but tried to avoid overwriting original PNG file(s) to keep them safe/available in case they are needed in the future. I suppose one can always go back in commit history for them.

[jdm]

@bors-servo r+

[bors-servo]

📌 Commit 4ea7da8 has been approved by jdm

[bors-servo]

⌛ Testing commit 4ea7da8 with merge e3a5f36...

[bors-servo]

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing e3a5f36 to master...

[atouchet]

This doesn't appear to have updated the logo on Windows. Servo.ico, servo.png, and servo64.png are still using the old logo.

[malqinneh]

This doesn't appear to have updated the logo on Windows. Servo.ico, servo.png, and servo64.png are still using the old logo.

Probably due to file name(s). In order for the new assets to simply replace the old ones, they need to have the same name as the old assets. Alternatively, we can update the line of code that references old asset names to the new names.

[atouchet]

@malqinneh I'm not sure what the best approach would be but I took a quick look and it appears the relevant references are here:

servo/ports/glutin/build.rs

Line 15 in a9f7b13

res.set_icon("../../resources/Servo.ico");

servo/python/servo/build_commands.py

Line 722 in 8f3622a

icon_path = path.join(self.get_top_dir(), "resources", "servo.png")

servo/ports/glutin/headed_window.rs

Line 149 in e07f028

let icon_bytes = include_bytes!("../../resources/servo64.png");

[malqinneh]

@atouchet happy to update those items. I need to create a new fork of the Servo branch since the last one I started was merged, is that correct?

[atouchet]

That should work. Taking another look at the files in /resources I suspect that servo.icns may be another file that needs updating but it appears to be an Apple image format and I don't have a Mac.

Edit: The reference to servo.icns is located at:

servo/Info.plist

Line 10 in 16bdf92

<string>servo.icns</string>

[malqinneh]

@atouchet created a new pull request. Let me know if we missed anything. Thank you very much for your help and patience 👍

[atouchet]

Thanks! I will take a look at the PR.