Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install setuptools along with virtualenv. #25758

Closed
wants to merge 3 commits into from
Closed

Install setuptools along with virtualenv. #25758

wants to merge 3 commits into from
+1 −1

Conversation

@jdm
Copy link
Member

jdm commented Feb 13, 2020

Fix #25757.
@jdm
Install setuptools along with virtualenv.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2e704d5
@jdm
Copy link
Member Author

jdm commented Feb 13, 2020 

Collecting setuptools
  Downloading https://files.pythonhosted.org/packages/f9/d3/955738b20d3832dfa3cd3d9b07e29a8162edb480bf988332f5e6e48ca444/setuptools-44.0.0-py2.py3-none-any.whl (583kB)
Collecting virtualenv
  Downloading https://files.pythonhosted.org/packages/18/cb/9799b00a192391cab56f1e6400bfdeb331afff7527e18dc3df25543782ff/virtualenv-20.0.3-py2.py3-none-any.whl (4.6MB)
Collecting filelock<4,>=3.0.0 (from virtualenv)
  Downloading https://files.pythonhosted.org/packages/14/ec/6ee2168387ce0154632f856d5cc5592328e9cf93127c5c9aeca92c8c16cb/filelock-3.0.12.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
    ImportError: No module named setuptools
jdm added 2 commits Feb 13, 2020
@jdm
Force older versions of virtualenv.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6196b89
@jdm
Use proper bash syntax.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
87ff684
@jdm
Copy link
Member Author

jdm commented Feb 13, 2020

The docker image creation succeeded when I limited the virtualenv module version to <20.
@jdm
Copy link
Member Author

jdm commented Feb 13, 2020

r? @SimonSapin
@highfive highfive assigned SimonSapin and unassigned paulrouget Feb 13, 2020
@SimonSapin SimonSapin mentioned this pull request Feb 13, 2020
Merged
@jdm jdm marked this pull request as ready for review Feb 13, 2020
bors-servo added a commit that referenced this pull request Feb 14, 2020
@bors-servo
Auto merge of #25759 - servo:venv, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e60d623 
Install virtualenv through APT, in Docker images

Fix #25757
Close #25758
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
S-awaiting-review
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Docker image creation is busted
4 participants
@jdm @SimonSapin @paulrouget @highfive
You can’t perform that action at this time.