Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upInstruct intallation of python-virtualenv #25761
Merged
+56
−45
Conversation
highfive
commented
Feb 14, 2020
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @nox (or someone else) soon. |
highfive
commented
Feb 14, 2020
|
Heads up! This PR modifies the following files:
|
luka-zitnik
force-pushed the
luka-zitnik:python-virtualenv-missing
branch
from
40e0659
to
a15775b
jdm
changed the title
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 15, 2020
Instruct intallation of python-virtualenv Fixes #23210 Closes #23212 <!-- Please describe your changes on the following line: --> (Re-)enable `./mach bootstrap` by requiring a separate installation step for packages python, python-pip and python-virtualenv. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23210 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because bootstrap command is not covered by tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Feb 15, 2020
Instruct intallation of python-virtualenv Fixes #23210 Closes #23212 <!-- Please describe your changes on the following line: --> (Re-)enable `./mach bootstrap` by requiring a separate installation step for packages python, python-pip and python-virtualenv. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23210 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because bootstrap command is not covered by tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Feb 15, 2020
Instruct intallation of python-virtualenv Fixes #23210 Closes #23212 <!-- Please describe your changes on the following line: --> (Re-)enable `./mach bootstrap` by requiring a separate installation step for packages python, python-pip and python-virtualenv. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23210 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because bootstrap command is not covered by tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Feb 20, 2020
Instruct intallation of python-virtualenv Fixes #23210 Closes #23212 <!-- Please describe your changes on the following line: --> (Re-)enable `./mach bootstrap` by requiring a separate installation step for packages python, python-pip and python-virtualenv. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23210 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because bootstrap command is not covered by tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Feb 20, 2020
Instruct intallation of python-virtualenv Fixes #23210 Closes #23212 <!-- Please describe your changes on the following line: --> (Re-)enable `./mach bootstrap` by requiring a separate installation step for packages python, python-pip and python-virtualenv. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #23210 <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because bootstrap command is not covered by tests <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
@bors-servo retry |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
luka-zitnik commentedFeb 14, 2020
•
edited
Fixes #23210
Closes #23212
(Re-)enable
./mach bootstrapby requiring a separate installation step for packages python, python-pip and python-virtualenv../mach build -ddoes not report any errors./mach test-tidydoes not report any errors