Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd initial support for WebGL2 read framebuffer #25765
Merged
+394
−89
Conversation
Adds support for using the WebGL2 enums `MAX_COLOR_ATTACHMENTS` and `MAX_DRAW_BUFFERS` with `GetParameter`. See https://www.khronos.org/registry/webgl/specs/latest/2.0/#3.7.2
Adds support for binding to the read framebuffer slot and querying its status.
highfive
commented
Feb 14, 2020
|
Heads up! This PR modifies the following files:
|
highfive
commented
Feb 14, 2020
|
|
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 18, 2020
…=jdm Add initial support for WebGL2 read framebuffer Adds support for binding to the read framebuffer slot and querying its status. <!-- Please describe your changes on the following line: --> Depends on #25752 cc @jdm @zakorgy --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Feb 18, 2020
…=jdm Add initial support for WebGL2 read framebuffer Adds support for binding to the read framebuffer slot and querying its status. <!-- Please describe your changes on the following line: --> Depends on #25752 cc @jdm @zakorgy --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Feb 18, 2020
…=jdm Add initial support for WebGL2 read framebuffer Adds support for binding to the read framebuffer slot and querying its status. <!-- Please describe your changes on the following line: --> Depends on #25752 cc @jdm @zakorgy --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Feb 18, 2020
…=jdm Add initial support for WebGL2 read framebuffer Adds support for binding to the read framebuffer slot and querying its status. <!-- Please describe your changes on the following line: --> Depends on #25752 cc @jdm @zakorgy --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 20, 2020
…, r=jdm Add support for WebGL2 framebuffer attachments Adds an initial implementation for the framebuffer attachments introduced with WebGL2 and the related enums and constrains checks. <!-- Please describe your changes on the following line: --> Depends on #25765. cc @jdm @zakorgy --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo
added a commit
that referenced
this pull request
Feb 21, 2020
…, r=jdm Add support for WebGL2 framebuffer attachments Adds an initial implementation for the framebuffer attachments introduced with WebGL2 and the related enums and constrains checks. <!-- Please describe your changes on the following line: --> Depends on #25765. cc @jdm @zakorgy --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo
added a commit
that referenced
this pull request
Feb 21, 2020
…, r=jdm Add support for WebGL2 framebuffer attachments Adds an initial implementation for the framebuffer attachments introduced with WebGL2 and the related enums and constrains checks. <!-- Please describe your changes on the following line: --> Depends on #25765. cc @jdm @zakorgy --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo
added a commit
that referenced
this pull request
Feb 21, 2020
…, r=jdm Add support for WebGL2 framebuffer attachments Adds an initial implementation for the framebuffer attachments introduced with WebGL2 and the related enums and constrains checks. <!-- Please describe your changes on the following line: --> Depends on #25765. cc @jdm @zakorgy --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo
added a commit
that referenced
this pull request
Feb 21, 2020
…, r=jdm Add support for WebGL2 framebuffer attachments Adds an initial implementation for the framebuffer attachments introduced with WebGL2 and the related enums and constrains checks. <!-- Please describe your changes on the following line: --> Depends on #25765. cc @jdm @zakorgy --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mmatyas commentedFeb 14, 2020
Adds support for binding to the read framebuffer slot and querying its status.
Depends on #25752
cc @jdm @zakorgy
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors