Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upsupportsSession() -> isSessionSupported() #25770
Merged
Conversation
highfive
commented
Feb 15, 2020
|
Heads up! This PR modifies the following files:
|
highfive
commented
Feb 15, 2020
|
|
|
Needs a |
|
@bors-servo r=jdm |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 15, 2020
|
|
|
@bors-servo r=jdm |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 15, 2020
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Feb 15, 2020
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Feb 15, 2020
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 15, 2020
Always trigger an input sources change event on session creation Fixes our behavior to match the spec, and to specifically do it in a way that makes sense. This is also what Chromium does currently, though I'm not sure if it does the scheduling the same way. The spec for this may change, see immersive-web/webxr#961. This fix, along with #25770 , makes three.js content work on servo. Instead of this fix we can also wait for mrdoob/three.js#18638 to land (which isn't certain until we figure out more about immersive-web/webxr#961 ) Even if immersive-web/webxr#961 decides to choose the option that obviates this patch, we should probably keep it for now since there's already content out in the wild relying on this behavior. r? @jdm @asajeffrey
bors-servo
added a commit
that referenced
this pull request
Feb 15, 2020
Always trigger an input sources change event on session creation Fixes our behavior to match the spec, and to specifically do it in a way that makes sense. This is also what Chromium does currently, though I'm not sure if it does the scheduling the same way. The spec for this may change, see immersive-web/webxr#961. This fix, along with #25770 , makes three.js content work on servo. Instead of this fix we can also wait for mrdoob/three.js#18638 to land (which isn't certain until we figure out more about immersive-web/webxr#961 ) Even if immersive-web/webxr#961 decides to choose the option that obviates this patch, we should probably keep it for now since there's already content out in the wild relying on this behavior. r? @jdm @asajeffrey
bors-servo
added a commit
that referenced
this pull request
Feb 16, 2020
Always trigger an input sources change event on session creation Fixes our behavior to match the spec, and to specifically do it in a way that makes sense. This is also what Chromium does currently, though I'm not sure if it does the scheduling the same way. The spec for this may change, see immersive-web/webxr#961. This fix, along with #25770 , makes three.js content work on servo. Instead of this fix we can also wait for mrdoob/three.js#18638 to land (which isn't certain until we figure out more about immersive-web/webxr#961 ) Even if immersive-web/webxr#961 decides to choose the option that obviates this patch, we should probably keep it for now since there's already content out in the wild relying on this behavior. r? @jdm @asajeffrey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedFeb 15, 2020
r? @jdm
fixes #25596