Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSync WPT with upstream (17-02-2020) #25783
Merged
+664,929
−857,980
Conversation
…2bcf8ce44
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 17, 2020
…wpt-sync Sync WPT with upstream (17-02-2020) Automated downstream sync of changes from upstream as of 17-02-2020. [no-wpt-sync] r? @servo-wpt-sync
highfive
commented
Feb 17, 2020
|
Heads up! This PR modifies the following files:
|
|
|
After WPT moves to "Manifest path trie RFC", we don't have the `paths` field in manifest anymore. But, we still have file hash in the `items` field; the simplest way to diff between manifests is to compare the raw string value of the `items` field. When we have different manifests, we must have different items field in the manifest json.
This was referenced Feb 19, 2020
|
The fix for both issues is at servo-wpt-sync#1 |
|
@bors-servo r+ |
|
|
@bors-servo r- |
|
I'm fixing these locally. |
|
@bors-servo r+ |
|
|
|
@bors-servo retry
|
bors-servo
added a commit
that referenced
this pull request
Feb 20, 2020
Sync WPT with upstream (17-02-2020) Automated downstream sync of changes from upstream as of 17-02-2020. [no-wpt-sync] r? @servo-wpt-sync
|
|
|
Looks like they were intermittent results
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Feb 20, 2020
Sync WPT with upstream (17-02-2020) Automated downstream sync of changes from upstream as of 17-02-2020. [no-wpt-sync] r? @servo-wpt-sync
|
|
|
@bors-servo retry |
|
|
This was referenced Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
servo-wpt-sync commentedFeb 17, 2020
Automated downstream sync of changes from upstream as of 17-02-2020.
[no-wpt-sync]
r? @servo-wpt-sync