Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for WebGL2 framebuffer attachments #25784
Merged
Conversation
highfive
commented
Feb 17, 2020
|
Heads up! This PR modifies the following files:
|
highfive
commented
Feb 17, 2020
|
|
|
The implementation looks good, but could you please amend the three commits to recreate the expectations from scratch? Your fixes look like they only added failures because the test cases in the Khronos test suites are weirdly numbered programatically, and every time we support new APIs their numbers changes and most of the previous expectations become garbage. |
| constants::DEPTH_COMPONENT24 | | ||
| constants::DEPTH_COMPONENT32F | | ||
| constants::DEPTH24_STENCIL8 | | ||
| constants::DEPTH32F_STENCIL8 | |
This comment has been minimized.
This comment has been minimized.
jdm
Feb 19, 2020
Member
I'm concerned that adding these formats here will make them usable from webgl1 contexts when they shouldn't be. Perhaps we should have an argument the caller passes in to indicate which kind of context it is?
This comment has been minimized.
This comment has been minimized.
mmatyas
Feb 20, 2020
Author
Contributor
Hm you might be right, I've added an additional check for this case.
| @@ -213,91 +219,138 @@ impl WebGLFramebuffer { | |||
| self.size.get() | |||
| } | |||
|
|
|||
| fn check_attachment_constrains( | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Sorry, left review comments yesterday and forgot to submit them. |
mmatyas
force-pushed the
szeged:mmatyas__webgl_fns_framebuf_attachments
branch
from
d54285b
to
1bea2c7
|
@nox Ah, I might have accidentally left some of such tests in the commits, will fix it. |
mmatyas
force-pushed the
szeged:mmatyas__webgl_fns_framebuf_attachments
branch
from
1bea2c7
to
d7bc0e0
|
Also rebased to master, now that the earlier patches have landed. |
mmatyas
force-pushed the
szeged:mmatyas__webgl_fns_framebuf_attachments
branch
from
d7bc0e0
to
08b675f
|
Error syncing changes upstream. Logs saved in error-snapshot-1582203730577. |
mmatyas
force-pushed the
szeged:mmatyas__webgl_fns_framebuf_attachments
branch
from
08b675f
to
974b0f3
|
@bors-servo r+ |
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Feb 21, 2020
…, r=jdm Add support for WebGL2 framebuffer attachments Adds an initial implementation for the framebuffer attachments introduced with WebGL2 and the related enums and constrains checks. <!-- Please describe your changes on the following line: --> Depends on #25765. cc @jdm @zakorgy --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Feb 21, 2020
…, r=jdm Add support for WebGL2 framebuffer attachments Adds an initial implementation for the framebuffer attachments introduced with WebGL2 and the related enums and constrains checks. <!-- Please describe your changes on the following line: --> Depends on #25765. cc @jdm @zakorgy --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
@bors-servo retry |
|
|
This was referenced Feb 21, 2020
bors-servo
added a commit
that referenced
this pull request
Feb 21, 2020
…m, r=jdm Add support for WebGL2 getFramebufferAttachmentParameter Implements the WebGL2 variant of `getFramebufferAttachmentParameter` and the related parameter checks. See: https://www.khronos.org/registry/webgl/specs/latest/2.0/#3.7.4 <!-- Please describe your changes on the following line: --> Depends on #25784 cc @jdm @zakorgy --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo
added a commit
that referenced
this pull request
Feb 21, 2020
…m, r=jdm Add support for WebGL2 getFramebufferAttachmentParameter Implements the WebGL2 variant of `getFramebufferAttachmentParameter` and the related parameter checks. See: https://www.khronos.org/registry/webgl/specs/latest/2.0/#3.7.4 <!-- Please describe your changes on the following line: --> Depends on #25784 cc @jdm @zakorgy --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mmatyas commentedFeb 17, 2020
Adds an initial implementation for the framebuffer attachments introduced with WebGL2 and the related enums and constrains checks.
Depends on #25765.
cc @jdm @zakorgy
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors