Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd layout_2020 support for filters and mix-blend-mode #25788
Merged
+19,656
−69
Conversation
highfive
commented
Feb 18, 2020
|
|
||
| /// CSS filters to be applied to this stacking context (including opacity). | ||
| filters: Vec<wr::FilterOp>, | ||
|
|
||
| /// The blend mode with which this stacking context blends with its backdrop. | ||
| mix_blend_mode: wr::MixBlendMode, |
Comment on lines
68
to
73
This comment has been minimized.
This comment has been minimized.
SimonSapin
Feb 18, 2020
Member
Do these need to be kept in the stacking context tree, or could they be recomputed from the &ComputedValues style of the element that generates this stacking context?
This comment has been minimized.
This comment has been minimized.
mrobinson
Feb 18, 2020
Author
Member
I think they can be recomputed. I can try to organize the code in that way.
This comment has been minimized.
This comment has been minimized.
mrobinson
Feb 18, 2020
Author
Member
Okay. I've pushed a new version of this change that minimizes data members in the StackingContext data structure.
mrobinson
force-pushed the
mrobinson:stacking-contexts-v3a
branch
2 times, most recently
from
9123459
to
90f1bf0
|
r+ with two changes |
| @@ -414,3 +490,52 @@ impl AnonymousFragment { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| pub trait ToLayout { | |||
This comment has been minimized.
This comment has been minimized.
SimonSapin
Feb 18, 2020
Member
Could this reuse the geom::ToWebrender trait instead? (And perhaps move it to some other module since it’s not geometry-specific. Perhaps display_list/mod.rs since that’s the module that interacts most with WebRender?)
This comment has been minimized.
This comment has been minimized.
mrobinson
Feb 19, 2020
Author
Member
Great idea. I've moved this to a "conversions" module that is similar to the one in layout_2013.
| @@ -19,5 +19,7 @@ skip: true | |||
| skip: false | |||
| [css-backgrounds] | |||
| skip: false | |||
| [filter-effects] | |||
| skip: false | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mrobinson
force-pushed the
mrobinson:stacking-contexts-v3a
branch
from
90f1bf0
to
d03560b
|
@bors-servo r=SimonSapin |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 19, 2020
Add layout_2020 support for filters and mix-blend-mode --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
@bors-servo retry
|
bors-servo
added a commit
that referenced
this pull request
Feb 19, 2020
Add layout_2020 support for filters and mix-blend-mode --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
SimonSapin
added a commit
that referenced
this pull request
Feb 19, 2020
Add layout_2020 support for filters and mix-blend-mode --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mrobinson commentedFeb 18, 2020
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors