Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for WebGL2 clear buffer operations #25789
Merged
Conversation
highfive
commented
Feb 18, 2020
|
Heads up! This PR modifies the following files:
|
mmatyas
force-pushed the
szeged:mmatyas__webgl_fns_clearbuffer
branch
from
91958a8
to
7cf87ed
|
|
|
This can merge after a rebase. |
Adds support for the following WebGL2 methods: - `clearBufferfv` - `clearBufferiv` - `clearBufferuiv` - `clearBufferfi` See: https://www.khronos.org/registry/webgl/specs/latest/2.0/#3.7.11
mmatyas
force-pushed the
szeged:mmatyas__webgl_fns_clearbuffer
branch
from
7cf87ed
to
8701d45
|
Rebased and regenerated the tests. |
|
@bors-servo r+ |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mmatyas commentedFeb 18, 2020
Adds support for the following WebGL2 methods:
clearBufferfvclearBufferivclearBufferuivclearBufferfiSee: https://www.khronos.org/registry/webgl/specs/latest/2.0/#3.7.11
cc @jdm @zakorgy
Note: While the code itself doesn't depend on any other PRs, some of the tests do require WebGL2 framebuffer/renderbuffer support (#25785).
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors