Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement Broadcastchannel #25796
Merged
Implement Broadcastchannel #25796
Conversation
highfive
commented
Feb 18, 2020
|
Heads up! This PR modifies the following files:
|
highfive
commented
Feb 18, 2020
|
|
gterzian
force-pushed the
gterzian:implement_broadcast_channel
branch
from
a7ecb75
to
bf11296
|
Please @ me when you're ready for review! |
gterzian
force-pushed the
gterzian:implement_broadcast_channel
branch
5 times, most recently
from
8e0b1e3
to
575ba2a
gterzian
force-pushed the
gterzian:implement_broadcast_channel
branch
from
24c9d8a
to
55690c4
|
@bors-servo try=wpt |
bors-servo
added a commit
that referenced
this pull request
Feb 19, 2020
[WIP] Implement Broadcastchannel <!-- Please describe your changes on the following line: --> FIX #21025 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
gterzian
force-pushed the
gterzian:implement_broadcast_channel
branch
from
55690c4
to
9b75536
|
@bors-servo try=wpt |
bors-servo
added a commit
that referenced
this pull request
Feb 20, 2020
[WIP] Implement Broadcastchannel <!-- Please describe your changes on the following line: --> FIX #21025 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
|
|
|
gterzian
force-pushed the
gterzian:implement_broadcast_channel
branch
3 times, most recently
from
86d028a
to
cf71484
bors-servo
added a commit
that referenced
this pull request
Feb 25, 2020
…earth Implement Broadcastchannel <!-- Please describe your changes on the following line: --> FIX #21025 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
gterzian
force-pushed the
gterzian:implement_broadcast_channel
branch
from
b0adb83
to
1cb1f16
|
Transplanted upstreamable changes to existing PR. Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#21895. |
|
Just made a small correction to a doc comment, and it looks like I've missed a few test updates... |
gterzian
force-pushed the
gterzian:implement_broadcast_channel
branch
from
1cb1f16
to
fe8d77f
|
Transplanted upstreamable changes to existing PR. Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#21895. |
gterzian
force-pushed the
gterzian:implement_broadcast_channel
branch
from
fe8d77f
to
99e4d74
|
@bors-servo r=Manishearth Let's see if the below is a new intermittent, I marked it as TIMEOUT [expected OK] /html/semantics/forms/form-submission-target/rel-base-target.html |
|
|
|
Transplanted upstreamable changes to existing PR. Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#21895. |
|
|
|
Error syncing changes upstream. Logs saved in error-snapshot-1582615371429. |
Merged
|
web-platform-tests/wpt#21895 is not merged yet due to the syncing error |
|
Manually merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
gterzian commentedFeb 18, 2020
•
edited
FIX #21025
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors