Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide window #25799

Merged
merged 2 commits into from Feb 20, 2020
Merged

Hide window #25799

merged 2 commits into from Feb 20, 2020
+78 −1

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Feb 19, 2020

Stop animations when the window is hidden.

Tested with both Immersive Mode, and regular window being minimized.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #25794 (GitHub issue number if applicable)
paulrouget added 2 commits Feb 19, 2020
@paulrouget
Stop animations when window is hidden (API + UWP)
6ddde1a
@paulrouget
bump min target platform
Loading status checks…
e45af06
@highfive
Copy link

highfive commented Feb 19, 2020

Heads up! This PR modifies the following files:

  • @asajeffrey: components/constellation/constellation.rs
  • @cbrewster: components/constellation/constellation.rs
@Manishearth
Manishearth reviewed Feb 19, 2020
View changes
support/hololens/ServoApp/BrowserPage.cpp
@@ -71,6 +71,10 @@ void BrowserPage::BindServoEvents() {
? Visibility::Collapsed
: Visibility::Visible);
});
Window::Current().VisibilityChanged(

This comment has been minimized.

Sign in to view
Copy link
@Manishearth

Manishearth Feb 19, 2020

Member

I assume this gets called when we enter immersive mode on the hololens as well, right? Is there an FPS improvement?

This comment has been minimized.

Sign in to view
Copy link
@paulrouget

paulrouget Feb 20, 2020

Author Contributor

I assume this gets called when we enter immersive mode on the hololens as well, right?

Yes.

Is there an FPS improvement?

I haven't looked.

This comment has been minimized.

Sign in to view
Copy link
@paulrouget

paulrouget Feb 20, 2020

Author Contributor

I don't see obvious improvements, but the emulator is probably not the best way of measure that.
@Manishearth
Copy link
Member

Manishearth commented Feb 20, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Feb 20, 2020

📌 Commit e45af06 has been approved by Manishearth
@highfive highfive assigned Manishearth and unassigned SimonSapin Feb 20, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Feb 20, 2020

⌛ Testing commit e45af06 with merge 69051ae...
bors-servo added a commit that referenced this pull request Feb 20, 2020
@bors-servo
Auto merge of #25799 - paulrouget:hideWindow, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
69051ae 
Hide window

Stop animations when the window is hidden.

Tested with both Immersive Mode, and regular window being minimized.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #25794 (GitHub issue number if applicable)
@bors-servo
Copy link
Contributor

bors-servo commented Feb 20, 2020

💔 Test failed - status-taskcluster
@Manishearth
Copy link
Member

Manishearth commented Feb 20, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 20, 2020

⌛ Testing commit e45af06 with merge b2fc438...
bors-servo added a commit that referenced this pull request Feb 20, 2020
@bors-servo
Auto merge of #25799 - paulrouget:hideWindow, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b2fc438 
Hide window

Stop animations when the window is hidden.

Tested with both Immersive Mode, and regular window being minimized.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #25794 (GitHub issue number if applicable)
@bors-servo
Copy link
Contributor

bors-servo commented Feb 20, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Feb 20, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 20, 2020

⌛ Testing commit e45af06 with merge f1b4445...
bors-servo added a commit that referenced this pull request Feb 20, 2020
@bors-servo
Auto merge of #25799 - paulrouget:hideWindow, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f1b4445 
Hide window

Stop animations when the window is hidden.

Tested with both Immersive Mode, and regular window being minimized.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #25794 (GitHub issue number if applicable)
@bors-servo
Copy link
Contributor

bors-servo commented Feb 20, 2020

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Feb 20, 2020

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Feb 20, 2020

⌛ Testing commit e45af06 with merge b5b9732...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 20, 2020

☀️ Test successful - status-taskcluster
Approved by: Manishearth
Pushing b5b9732 to master...
@bors-servo bors-servo merged commit b5b9732 into servo:master Feb 20, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@jdm jdm mentioned this pull request Feb 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth

Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

In immersive mode, make sure to mark the window as not visible
6 participants
@paulrouget @highfive @Manishearth @bors-servo @jdm @SimonSapin
You can’t perform that action at this time.