Update ipc-channel and crossbeam-channel #25806

jdm · 2020-02-19T22:57:18Z

Depends on servo/webxr#130 and servo/media#333.

highfive · 2020-02-19T22:57:24Z

Heads up! This PR modifies the following files:

@asajeffrey: components/script/Cargo.toml, components/constellation/pipeline.rs, components/constellation/Cargo.toml, components/constellation/constellation.rs, components/webdriver_server/Cargo.toml
@cbrewster: components/constellation/pipeline.rs, components/constellation/Cargo.toml, components/constellation/constellation.rs
@jgraham: components/webdriver_server/Cargo.toml
@KiChjang: components/net/filemanager_thread.rs, components/script/Cargo.toml, components/net_traits/Cargo.toml, components/net/Cargo.toml, components/script_traits/Cargo.toml
@emilio: components/style/Cargo.toml, components/layout/Cargo.toml

jdm · 2020-02-19T22:57:33Z


        Auto merge of #25806 - jdm:ipc-up, r=<try>

Update ipc-channel and crossbeam-channel

bors-servo · 2020-02-19T22:57:38Z

⌛ Trying commit 685c4de with merge a319700...

bors-servo · 2020-02-19T23:32:10Z

💔 Test failed - status-taskcluster

jdm · 2020-02-19T23:56:25Z


  â–¶ OK [expected ERROR] /webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-multi-channels.html

  â–¶ Unexpected subtest result in /webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-multi-channels.html:
  â”” PASS [expected TIMEOUT] Executing "initialize"

  â–¶ Unexpected subtest result in /webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-multi-channels.html:
  â”” PASS [expected NOTRUN] Executing "test"

  â–¶ Unexpected subtest result in /webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-multi-channels.html:
  â”” PASS [expected NOTRUN] Audit report

  â–¶ Unexpected subtest result in /webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-multi-channels.html:
  â”‚ FAIL [expected PASS] X Rendered audio for channel 5 does not equal [0,0.0626220703125,0.125030517578125,0.18695068359375,0.24810791015625,0.308319091796875,0.3673095703125,0.42486572265625,0.480743408203125,0.53472900390625,0.58660888671875,0.636199951171875,0.68328857421875,0.727691650390625,0.76922607421875,0.8077392578125...] with an element-wise tolerance of {"absoluteThreshold":0.000030517578125,"relativeThreshold":0}.\n\tIndex\tActual\t\t\tExpected\t\tAbsError\t\tRelError\t\tTest threshold\n\t[1]\t3.6732959747314453e-1\t6.2622070312500000e-2\t3.0470752716064453e-1\t4.8658168859649127e+0\t3.0517578125000000e-5\n\t[2]\t6.8329977989196777e-1\t1.2503051757812500e-1\t5.5826926231384277e-1\t4.4650639949963384e+0\t3.0517578125000000e-5\n\t[3]\t9.0373212099075317e-1\t1.8695068359375000e-1\t7.1678143739700317e-1\t3.8340669508039502e+0\t3.0517578125000000e-5\n\t[4]\t9.9780619144439697e-1\t2.4810791015625000e-1\t7.4969828128814697e-1\t3.0216621502152523e+0\t3.0517578125000000e-5\n\t[5]\t9.5236867666244507e-1\t3.0831909179687500e-1\t6.4404958486557007e-1\t2.0889059484187866e+0\t3.0517578125000000e-5\n\t...and 44060 more errors.\n\tMax AbsError of 1.9961981773376465e+0 at index of 38383.\n\t[38383]\t-9.9879217147827148e-1\t9.9740600585937500e-1\t1.9961981773376465e+0\t2.0013897706758867e+0\t3.0517578125000000e-5\n\tMax RelError of Infinity at index of 1764.\n\t[1764]\t-5.8778524398803711e-1\t0.0000000000000000e+0\t5.8778524398803711e-1\tInfinity\t3.0517578125000000e-5\n
  â”‚   â†’ assert_true: expected true got false
  â”‚ 
  â”‚ _logFailed/<@http://web-platform.test:8000/webaudio/resources/audit.js:50:7
  â”‚ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2024:25
  â”‚ test@http://web-platform.test:8000/resources/testharness.js:548:30
  â”‚ _logFailed@http://web-platform.test:8000/webaudio/resources/audit.js:49:5
  â”‚ _finalize@http://web-platform.test:8000/webaudio/resources/audit.js:215:9
  â”‚ _assert@http://web-platform.test:8000/webaudio/resources/audit.js:228:12
  â”‚ beCloseToArray@http://web-platform.test:8000/webaudio/resources/audit.js:1019:19
  â”” @http://web-platform.test:8000/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-multi-channels.html:67:26

  â–¶ Unexpected subtest result in /webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-multi-channels.html:
  â”‚ FAIL [expected PASS] < [test] 1 out of 6 assertions were failed.
  â”‚   â†’ assert_true: expected true got false
  â”‚ 
  â”‚ _logFailed/<@http://web-platform.test:8000/webaudio/resources/audit.js:50:7
  â”‚ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2024:25
  â”‚ test@http://web-platform.test:8000/resources/testharness.js:548:30
  â”‚ _logFailed@http://web-platform.test:8000/webaudio/resources/audit.js:49:5
  â”‚ done@http://web-platform.test:8000/webaudio/resources/audit.js:1225:9
  â”” @http://web-platform.test:8000/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-multi-channels.html:72:34

  â–¶ Unexpected subtest result in /webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-multi-channels.html:
  â”‚ FAIL [expected PASS] # AUDIT TASK RUNNER FINISHED: 1 out of 2 tasks were failed.
  â”‚   â†’ assert_true: expected true got false
  â”‚ 
  â”‚ _logFailed/<@http://web-platform.test:8000/webaudio/resources/audit.js:50:7
  â”‚ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2024:25
  â”‚ test@http://web-platform.test:8000/resources/testharness.js:548:30
  â”‚ _logFailed@http://web-platform.test:8000/webaudio/resources/audit.js:49:5
  â”‚ _finish@http://web-platform.test:8000/webaudio/resources/audit.js:1282:9
  â”‚ run/<@http://web-platform.test:8000/webaudio/resources/audit.js:1343:31
  â”‚ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2024:25
  â”‚ promise_test/tests.promise_tests</<@http://web-platform.test:8000/resources/testharness.js:605:36
  â”” promise_test/tests.promise_tests<@http://web-platform.test:8000/resources/testharness.js:604:20


  â–¶ Unexpected subtest result in /webaudio/the-audio-api/the-audioparam-interface/setValueAtTime-within-block.html:
  â”‚ FAIL [expected PASS] Test setValueAtTime with start time not on a block boundary
  â”‚   â†’ assert_equals: default gain at sample 0 expected (number) 1 but got (undefined) undefined
  â”‚ 
  â”” @http://web-platform.test:8000/webaudio/the-audio-api/the-audioparam-interface/setValueAtTime-within-block.html:37:9


  â–¶ Unexpected subtest result in /webaudio/the-audio-api/the-audioparam-interface/setTargetAtTime-after-event-within-block.html:
  â”‚ FAIL [expected PASS] Test setTargetAtTime after an event in the same processing block
  â”‚   â†’ assert_equals: default gain at sample 0 expected (number) 1 but got (undefined) undefined
  â”‚ 
  â”” @http://web-platform.test:8000/webaudio/the-audio-api/the-audioparam-interface/setTargetAtTime-after-event-within-block.html:40:9


        Update ipc-channel and crossbeam-channel.


        Update rayon.


        Update tokio-threadpool.


        Update redox_users.


        Update tokio-executor.


        Update tokio-timer.


        Update duplicates.

jdm · 2020-02-20T16:16:47Z

@bors-servo try=wpt

bors-servo · 2020-02-20T16:16:54Z

⌛ Trying commit c129ed4 with merge 898f0c1...


        Auto merge of #25806 - jdm:ipc-up, r=<try>

Update ipc-channel and crossbeam-channel Depends on servo/webxr#130 and servo/media#333.

Manishearth

wait, has this sped up IPC to the extent that it affects the perf of audio tests? neat.

jdm · 2020-02-20T16:22:13Z

error: unused import: `glib::glib_bool_error`
  --> ports/gstplugin/servowebsrc.rs:15:5
   |
15 | use glib::glib_bool_error;
   |     ^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `-D unused-imports` implied by `-D warnings`
error[E0599]: no function or associated item named `from_string` found for struct `gstreamer::caps::Caps` in the current scope
   --> ports/gstplugin/servowebsrc.rs:522:30
    |
522 |         let src_caps = Caps::from_string(CAPS).unwrap();
    |                              ^^^^^^^^^^^ function or associated item not found in `gstreamer::caps::Caps`
error[E0308]: mismatched types
   --> ports/gstplugin/servowebsrc.rs:549:31
    |
549 |                 *guard = Some(url);
    |                               ^^^ expected struct `std::string::String`, found enum `std::option::Option`
    |
    = note: expected struct `std::string::String`
                 found enum `std::option::Option<_>`
error[E0599]: no method named `ok_or_else` found for enum `std::result::Result<gstreamer_video::video_info::VideoInfo, glib::error::BoolError>` in the current scope
   --> ports/gstplugin/servowebsrc.rs:575:14
    |
575 |             .ok_or_else(|| gst_loggable_error!(CATEGORY, "Failed to get video info"))?;
    |              ^^^^^^^^^^ help: there is a method with a similar name: `map_or_else`
error[E0308]: mismatched types
   --> ports/gstplugin/servowebsrc.rs:581:29
    |
581 |             .and_then(|cap| cap.get::<Fraction>("framerate"));
    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |                             |
    |                             expected enum `std::option::Option`, found enum `std::result::Result`
    |                             help: try using a variant of the expected enum: `Some(cap.get::<Fraction>("framerate"))`
    |
    = note: expected enum `std::option::Option<_>`
               found enum `std::result::Result<std::option::Option<gstreamer::value::Fraction>, gstreamer::structure::GetError<'_>>`

jdm · 2020-02-20T16:22:51Z

wait, has this sped up IPC to the extent that it affects the perf of audio tests? neat.

No, the non-timing out test comes from servo/media@7c88852.

jdm · 2020-02-20T16:48:33Z

@bors-servo try=linux

bors-servo · 2020-02-20T16:48:40Z

⌛ Trying commit 9934e0c with merge 16a0ca8...


        Auto merge of #25806 - jdm:ipc-up, r=<try>

Update ipc-channel and crossbeam-channel Depends on servo/webxr#130 and servo/media#333.

bors-servo · 2020-02-20T17:16:22Z

💔 Test failed - status-taskcluster

bors-servo · 2020-02-20T21:52:59Z

💔 Test failed - status-taskcluster

jdm · 2020-02-20T21:57:13Z

@bors-servo retry

#24726

bors-servo · 2020-02-20T22:32:57Z

⌛ Testing commit eafd006 with merge 46d2877...


        Auto merge of #25806 - jdm:ipc-up, r=Manishearth

Update ipc-channel and crossbeam-channel Depends on servo/webxr#130 and servo/media#333.

bors-servo · 2020-02-20T22:51:45Z

💔 Test failed - status-taskcluster

jdm · 2020-02-20T22:58:24Z

@bors-servo retry

#24726

bors-servo · 2020-02-20T23:11:18Z

⌛ Testing commit eafd006 with merge 81c8d6b...


        Auto merge of #25806 - jdm:ipc-up, r=Manishearth

Update ipc-channel and crossbeam-channel Depends on servo/webxr#130 and servo/media#333.

bors-servo · 2020-02-20T23:27:39Z

💔 Test failed - status-taskcluster

jdm · 2020-02-20T23:35:49Z

@bors-servo retry

#24726

bors-servo · 2020-02-20T23:47:14Z

⌛ Testing commit eafd006 with merge c78f0d7...

bors-servo · 2020-02-21T00:04:58Z

☀️ Test successful - status-taskcluster
Approved by: Manishearth
Pushing c78f0d7 to master...

highfive assigned Manishearth Feb 19, 2020

highfive added the S-awaiting-review label Feb 19, 2020

highfive added the S-tests-failed label Feb 19, 2020

jdm added 7 commits Feb 19, 2020

Update ipc-channel and crossbeam-channel.

3fd3c23

Update rayon.

d9c13b7

Update tokio-threadpool.

86a0de8

Update redox_users.

2445efc

Update tokio-executor.

1a680f7

Update tokio-timer.

1b90454

Update duplicates.

b13a37d

jdm force-pushed the jdm:ipc-up branch from 685c4de to c129ed4 Feb 20, 2020

highfive removed the S-tests-failed label Feb 20, 2020

jdm marked this pull request as ready for review Feb 20, 2020

Manishearth approved these changes Feb 20, 2020

View changes

jdm force-pushed the jdm:ipc-up branch from c129ed4 to 9934e0c Feb 20, 2020

highfive added the S-awaiting-merge label Feb 20, 2020

highfive added S-tests-failed and removed S-awaiting-merge labels Feb 20, 2020

highfive added S-awaiting-merge and removed S-tests-failed labels Feb 20, 2020

highfive added S-tests-failed and removed S-awaiting-merge labels Feb 20, 2020

highfive added S-awaiting-merge and removed S-tests-failed labels Feb 20, 2020

highfive added S-tests-failed and removed S-awaiting-merge labels Feb 20, 2020

highfive added S-awaiting-merge and removed S-tests-failed labels Feb 20, 2020

bors-servo merged commit c78f0d7 into servo:master Feb 21, 2020
2 checks passed

2 checks passed

Community-TC (pull_request) TaskGroup: success
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Feb 21, 2020

This was referenced Feb 21, 2020

Generate ::before and ::after content for layout_2020 #25817

Merged

Update SpiderMonkey #25678

Merged

servo / servo

Update ipc-channel and crossbeam-channel #25806

Update ipc-channel and crossbeam-channel #25806

jdm commented Feb 19, 2020 •

edited

highfive commented Feb 19, 2020

jdm commented Feb 19, 2020

bors-servo commented Feb 19, 2020

bors-servo commented Feb 19, 2020

jdm commented Feb 19, 2020

jdm commented Feb 20, 2020

bors-servo commented Feb 20, 2020

Manishearth left a comment

jdm commented Feb 20, 2020

jdm commented Feb 20, 2020

jdm commented Feb 20, 2020

bors-servo commented Feb 20, 2020

bors-servo commented Feb 20, 2020

bors-servo commented Feb 20, 2020

jdm commented Feb 20, 2020

bors-servo commented Feb 20, 2020

bors-servo commented Feb 20, 2020

jdm commented Feb 20, 2020

bors-servo commented Feb 20, 2020

bors-servo commented Feb 20, 2020

jdm commented Feb 20, 2020

bors-servo commented Feb 20, 2020

bors-servo commented Feb 21, 2020

servo / servo

Join GitHub today

Update ipc-channel and crossbeam-channel #25806

Update ipc-channel and crossbeam-channel #25806

Conversation

jdm commented Feb 19, 2020 • edited

highfive commented Feb 19, 2020

jdm commented Feb 19, 2020

bors-servo commented Feb 19, 2020

bors-servo commented Feb 19, 2020

jdm commented Feb 19, 2020

jdm commented Feb 20, 2020

bors-servo commented Feb 20, 2020

Manishearth left a comment

jdm commented Feb 20, 2020

jdm commented Feb 20, 2020

jdm commented Feb 20, 2020

bors-servo commented Feb 20, 2020

bors-servo commented Feb 20, 2020

bors-servo commented Feb 20, 2020

jdm commented Feb 20, 2020

bors-servo commented Feb 20, 2020

bors-servo commented Feb 20, 2020

jdm commented Feb 20, 2020

bors-servo commented Feb 20, 2020

bors-servo commented Feb 20, 2020

jdm commented Feb 20, 2020

bors-servo commented Feb 20, 2020

bors-servo commented Feb 21, 2020

jdm commented Feb 19, 2020 •

edited