Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upThread vslatestinstalled feature to the top #25809
Merged
Conversation
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 20, 2020
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Feb 20, 2020
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Feb 20, 2020
|
|
|
@bors-servo retry
|
bors-servo
added a commit
that referenced
this pull request
Feb 20, 2020
|
|
|
@bors-servo retry
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedFeb 20, 2020
I've been building with this to get pure-VS 2019 to work. Ideally we don't need any extra flags, but for now at least worth getting into master so I don't have to cherry pick this all the time.
r? @jdm